-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
taxonomy: flaxseed fiber #6945
taxonomy: flaxseed fiber #6945
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this! The PR seems to be failing the unit-tests. We should look into why before merging
taxonomies/ingredients.txt
Outdated
@@ -81685,18 +81714,25 @@ sv:falafel | |||
wikidata:en:Q188788 | |||
wikipedia:en:https://en.wikipedia.org/wiki/Falafel | |||
|
|||
# don't put fruit concentrate in fruit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not? It would seem reasonable to say that if a product contains fruit concentrate, it contains fruit I think. It's just a guess, but isn't fruit concentrate just fruit with less water?
@yuktea details about why the unit test is failing:
@moon-rabbitOFF : we already had a "fruit concentrates" entry (the canonical name should indeed be "fruit concentrate" ). Can you merge it into the entry you added?
|
There are some failing tests that needs to be adjusted:
|
@moon-rabbitOFF I'm fixing the tests etc. I'll add "vegetable protein" as a synonym of "plant protein" |
Kudos, SonarCloud Quality Gate passed! |
* refactor: adding perltidy to t/lang.t (#7044) Implementing perltidy to t/lang.t , will have a merge conflict with PR 6085 * taxonomy: add new Polish translations (#7068) * Polish translations of meat * add additinal polish translations of popular ingredients * taxonomy: Corrections to cheeses (#7065) Update categories.txt * refactor: adding perltidy to files (#7070) Implementing perltidy to t/dataquality.t , t/dataqualityfood.t , t/export.t * taxonomy: flaxseed fiber (#6945) * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * update taxonomy and tests Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org> * docs: Add how-to for remote dev (Gitpod) (#7053) * docs: Add how-to for remote dev (Gitpod) * docs: Add references/badges for gitpod environments * feat: Nutrient levels knowledge panels with facts and recommendations (#6980) * feat: knowledge panels for nutrient levels #6947 * add quantity in nutrient panel title * facts + recommendations for salt * fixed conflict * add info and recommendations for sugars, fat and saturated fat * fix: fix vitamin b1 thiamin %DV (#7072) fix: fix vitamin b1 thiamin %DV #6882 * refactor: updating perl critic Changing the perl critic config file to make it easier to pick and choose what tests will run. * feat: perlcritic unused variables check * refactor: perlcritic github testing * fetch depth * add perlcritic * better error message * all errors * allow ProductOpener::PerlStandards * remove undef * comment out severity 3 Commented outunused variable, severity 3 so that there are less merge conflicts when implementing perltidy to files. * refactor: dont look into .git directory Making sure that perlcritic doesn't look into .git directory * adding perlcritic to Makefile * moving perlcritic to pull_request.yml * default for perlcritic * refactor: uncomment severity 3 * refactor: removing unused variables Co-authored-by: Teiron <12804636+Teiron@users.noreply.github.com> Co-authored-by: moon-rabbitOFF <34795011+moon-rabbitOFF@users.noreply.github.com> Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org> Co-authored-by: Tushar <ditsuke@protonmail.com>
* refactor: adding perltidy to t/lang.t (#7044) Implementing perltidy to t/lang.t , will have a merge conflict with PR 6085 * taxonomy: add new Polish translations (#7068) * Polish translations of meat * add additinal polish translations of popular ingredients * taxonomy: Corrections to cheeses (#7065) Update categories.txt * refactor: adding perltidy to files (#7070) Implementing perltidy to t/dataquality.t , t/dataqualityfood.t , t/export.t * taxonomy: flaxseed fiber (#6945) * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * update taxonomy and tests Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org> * docs: Add how-to for remote dev (Gitpod) (#7053) * docs: Add how-to for remote dev (Gitpod) * docs: Add references/badges for gitpod environments * feat: Nutrient levels knowledge panels with facts and recommendations (#6980) * feat: knowledge panels for nutrient levels #6947 * add quantity in nutrient panel title * facts + recommendations for salt * fixed conflict * add info and recommendations for sugars, fat and saturated fat * fix: fix vitamin b1 thiamin %DV (#7072) fix: fix vitamin b1 thiamin %DV #6882 * refactor: updating perl critic Changing the perl critic config file to make it easier to pick and choose what tests will run. * feat: perlcritic unused variables check * refactor: perlcritic github testing * fetch depth * add perlcritic * better error message * all errors * allow ProductOpener::PerlStandards * remove undef * comment out severity 3 Commented outunused variable, severity 3 so that there are less merge conflicts when implementing perltidy to files. * refactor: dont look into .git directory Making sure that perlcritic doesn't look into .git directory * adding perlcritic to Makefile * moving perlcritic to pull_request.yml * default for perlcritic * refactor: uncomment severity 3 * refactor: removing unused variables Co-authored-by: Teiron <12804636+Teiron@users.noreply.github.com> Co-authored-by: moon-rabbitOFF <34795011+moon-rabbitOFF@users.noreply.github.com> Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org> Co-authored-by: Tushar <ditsuke@protonmail.com>
* Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * update taxonomy and tests Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
* Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * update taxonomy and tests Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
* Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * update taxonomy and tests Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
* Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * update taxonomy and tests Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
No description provided.