refactor: uncomment severity 3 & remove unused variables #7060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dipietroR
changed the title
github-actions
bot
added
Display
🌳 Forest Footprint
stephanegigandet
approved these changes
Jul 13, 2022
alexgarel
approved these changes
Jul 13, 2022
This PR would get merged into perlcritic rather than the main branch, so when perlcritic gets merged into main, then this PR would be merged to main as well. |
Implementing perltidy to t/lang.t , will have a merge conflict with PR 6085
* Polish translations of meat * add additinal polish translations of popular ingredients
Update categories.txt
Implementing perltidy to t/dataquality.t , t/dataqualityfood.t , t/export.t
* Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * update taxonomy and tests Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
* docs: Add how-to for remote dev (Gitpod) * docs: Add references/badges for gitpod environments
fix: fix vitamin b1 thiamin %DV #6882
Changing the perl critic config file to make it easier to pick and choose what tests will run.
Commented outunused variable, severity 3 so that there are less merge conflicts when implementing perltidy to files.
Making sure that perlcritic doesn't look into .git directory
dipietroR
force-pushed
the
unused-variables
branch
from
519f7e5 to
7c6a334
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions
bot
added
categories
📚 Documentation
alexgarel
pushed a commit
that referenced
this pull request
Jul 19, 2022
* refactor: adding perltidy to t/lang.t (#7044) Implementing perltidy to t/lang.t , will have a merge conflict with PR 6085 * taxonomy: add new Polish translations (#7068) * Polish translations of meat * add additinal polish translations of popular ingredients * taxonomy: Corrections to cheeses (#7065) Update categories.txt * refactor: adding perltidy to files (#7070) Implementing perltidy to t/dataquality.t , t/dataqualityfood.t , t/export.t * taxonomy: flaxseed fiber (#6945) * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * Update ingredients.txt * update taxonomy and tests Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org> * docs: Add how-to for remote dev (Gitpod) (#7053) * docs: Add how-to for remote dev (Gitpod) * docs: Add references/badges for gitpod environments * feat: Nutrient levels knowledge panels with facts and recommendations (#6980) * feat: knowledge panels for nutrient levels #6947 * add quantity in nutrient panel title * facts + recommendations for salt * fixed conflict * add info and recommendations for sugars, fat and saturated fat * fix: fix vitamin b1 thiamin %DV (#7072) fix: fix vitamin b1 thiamin %DV #6882 * refactor: updating perl critic Changing the perl critic config file to make it easier to pick and choose what tests will run. * feat: perlcritic unused variables check * refactor: perlcritic github testing * fetch depth * add perlcritic * better error message * all errors * allow ProductOpener::PerlStandards * remove undef * comment out severity 3 Commented outunused variable, severity 3 so that there are less merge conflicts when implementing perltidy to files. * refactor: dont look into .git directory Making sure that perlcritic doesn't look into .git directory * adding perlcritic to Makefile * moving perlcritic to pull_request.yml * default for perlcritic * refactor: uncomment severity 3 * refactor: removing unused variables Co-authored-by: Teiron <12804636+Teiron@users.noreply.github.com> Co-authored-by: moon-rabbitOFF <34795011+moon-rabbitOFF@users.noreply.github.com> Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org> Co-authored-by: Tushar <ditsuke@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uncommenting severity 3 to get rid of unused variables