Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: New Crowdin translations to review and merge #7158

Merged
merged 3 commits into from
Sep 3, 2022
Merged

Conversation

github-actions[bot]
Copy link
Contributor

No description provided.

@github-actions github-actions bot requested a review from a team as a code owner July 30, 2022 03:32
@github-actions github-actions bot added the Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org label Jul 30, 2022
@github-actions github-actions bot force-pushed the l10n_main branch 7 times, most recently from 0e0e11d to 8819f48 Compare August 6, 2022 03:26
@github-actions github-actions bot force-pushed the l10n_main branch 7 times, most recently from 1cef655 to 883cec8 Compare August 13, 2022 03:22
@github-actions github-actions bot force-pushed the l10n_main branch 3 times, most recently from a97c96d to 0d116f7 Compare August 16, 2022 03:47
po/common/ach.po Outdated Show resolved Hide resolved
@github-actions github-actions bot added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org labels Aug 16, 2022
@teolemon
Copy link
Member

po/common/uk.po:4493: 'msgid' and 'msgstr' entries do not both end with '\n'
msgfmt: found 1 fatal error
→ po/common/uk.po...contains errors!

@teolemon teolemon self-assigned this Aug 16, 2022
@github-actions github-actions bot force-pushed the l10n_main branch 5 times, most recently from 55ba6c8 to 24cb688 Compare August 21, 2022 03:35
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Aug 24, 2022
@github-actions github-actions bot force-pushed the l10n_main branch 2 times, most recently from b979e4b to dafe5bc Compare August 26, 2022 03:48
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Aug 26, 2022
@github-actions github-actions bot force-pushed the l10n_main branch 2 times, most recently from 66c7cc6 to e917f60 Compare August 28, 2022 03:40
po/common/ach.po Outdated Show resolved Hide resolved
@teolemon
Copy link
Member

Failed test at tests/unit/attributes.t line 249.

Structures begin differing at:

$got->{attribute_groups_fr}[5]{name} = '�tiquettes'

$expected->{attribute_groups_fr}[5]{name} = 'Labels'

{

po/common/fr.po Outdated Show resolved Hide resolved
@github-actions github-actions bot force-pushed the l10n_main branch 2 times, most recently from 909c134 to 8eb4585 Compare August 30, 2022 03:49
po/common/fr.po Outdated Show resolved Hide resolved
po/common/hi.po Outdated Show resolved Hide resolved
@teolemon
Copy link
Member

Failed test 'file '/opt/product-opener/html/images/misc/openfoodfacts-logo-af-178x150.png' exists'

at tests/unit/lang.t line 77.

Failed test 'file '/opt/product-opener/html/images/misc/openfoodfacts-logo-af-356x300.png' exists'

at tests/unit/lang.t line 77.

@github-actions github-actions bot force-pushed the l10n_main branch 3 times, most recently from baa12a5 to aa62494 Compare September 2, 2022 03:51
@teolemon
Copy link
Member

teolemon commented Sep 2, 2022

@stephanegigandet I don't quite understand why some ingredient tests can be failing in a branch based on main, which does not touch taxonomies

# Looks like you failed 1 test of 201.
tests/unit/ingredients_parsing.t .............. 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/201 subtests 
ingredients_text: Farine de blé contient Gluten (avec Farine de blé, Carbonate de calcium, Fer, Niacine, Thiamine), Lait entier • Eau
# Got:
[
  {
    'id' => 'en:whole-milk',
    'text' => 'Lait entier'
  },
  {
    'id' => 'en:water',
    'text' => 'Eau'
  }
]
# Expected:
[
  {
    'id' => 'en:wheat-flour',
    'ingredients' => [
      {
        'id' => 'en:wheat-flour',
        'text' => 'avec Farine de blé'
      },
      {
        'id' => 'en:e170i',
        'text' => 'Carbonate de calcium'
      },
      {
        'id' => 'en:iron',
        'text' => 'Fer'
      },
      {
        'id' => 'en:e375',
        'text' => 'Niacine'
      },
      {
        'id' => 'en:thiamin',
        'text' => 'Thiamine'
      }
    ],
    'text' => 'Farine de blé'
  },
  {
    'id' => 'en:whole-milk',
    'text' => 'Lait entier'
  },
  {
    'id' => 'en:water',
    'text' => 'Eau'
  }
]
ingredients_text: Wheatflour contains Gluten (with Wheatflour, Calcium Carbonate, Iron, Niacin, Thiamin)· Sugar, Palm Oil
# Got:
[
  {
    'id' => 'en:sugar',
    'text' => 'Sugar'
  },
  {
    'id' => 'en:palm-oil',
    'text' => 'Palm Oil'
  }
]
# Expected:
[
  {
    'id' => 'en:wheat-flour',
    'ingredients' => [
      {
        'id' => 'en:wheat-flour',
        'text' => 'Wheatflour'
      },
      {
        'id' => 'en:e170i',
        'text' => 'Calcium Carbonate'
      },
      {
        'id' => 'en:iron',
        'text' => 'Iron'
      },
      {
        'id' => 'en:e375',
        'text' => 'Niacine'
      },
      {
        'id' => 'en:thiamin',
        'text' => 'Thiamin'
      }
    ],
    'text' => 'Wheatflour'
  },
  {
    'id' => 'en:sugar',
    'text' => 'Sugar'
  },
  {
    'id' => 'en:palm-oil',
    'text' => 'Palm Oil'
  }
]

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Sep 2, 2022

@teolemon the failing test is not the ones you copied (those are the ingredients_parsing_todo.t : they always fail but are ignored).

The failing test is this one:

#   Failed test at tests/unit/ingredients_parsing.t line 673.
#          got: 'vitaminer, vitamin a, vitamin b, vitamin c. vitaminer, vitamin b2, vitamin e, vitamin d. kan inneholde : andre n�tter, kan inneholde : soya, kan inneholde : melk.'
#     expected: 'vitaminer, vitamin a, vitamin b, vitamin c. vitaminer, vitamin b2, vitamin e, vitamin d. spor : andre n�tter, spor : soya, spor : melk.'
Original ingredients: Vitaminer A, B og C. Vitaminer (B2, E, D). Kan inneholde spor av andre nøtter, soya og melk. (nb)

It's because the translation for "traces" has been changed, so the normalized version of the ingredients changed.

 msgctxt "traces"
 msgid "Traces"
-msgstr "Spor"
+msgstr "Kan inneholde"

It may be better to keep the original "Spor". Otherwise we can update the test.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon merged commit 955bb2e into main Sep 3, 2022
@teolemon teolemon deleted the l10n_main branch September 3, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants