Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW DESIGN: products not aligned on first row and last row of lists of products #7309

Open
Tracked by #7295
stephanegigandet opened this issue Sep 6, 2022 · 7 comments · Fixed by #8423
Open
Tracked by #7295
Assignees
Labels
🎨 Design Hacktoberfest 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Sep 6, 2022

https://world.openfoodfacts.dev/

The first products of the first row are slightly off:

image

In the last row, if we have less products than the previous row, it would be good to have them aligned with the previous row:

image

@eeshaanSA
Copy link

Would like to take this up. @stephanegigandet

@stephanegigandet
Copy link
Contributor Author

@eeshaanSA : thank you!

Corresponding code: https://github.com/openfoodfacts/openfoodfacts-server/blob/redesign2/templates/web/pages/product/product_page.tt.html

  • the SCSS code in /scss/

  • JS code in /html/js/product-search.js

@teolemon teolemon added 🎨 Design 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. labels Sep 28, 2022
@jainshubham766
Copy link

I would like to resolve this issue, under hacktoberfeast.
Please assign

@stephanegigandet
Copy link
Contributor Author

I would like to resolve this issue, under hacktoberfeast.
Please assign

@jainshubham766 Thanks, I assigned the issue to you.

@jainshubham766
Copy link

jainshubham766 commented Oct 15, 2022

@stephanegigandet Can u please specify the file to target? I will help me to resolve fast. Please share how I can run this project locally and debug it.

@stephanegigandet
Copy link
Contributor Author

@jainshubham766 you can set up the project locally in docker: https://github.com/openfoodfacts/openfoodfacts-server/blob/main/docs/introduction/dev-environment-quick-start-guide.md

The relevant files:

/scss/*.scss
/html/js/product-search.js

@jainshubham766 jainshubham766 removed their assignment Oct 18, 2022
@teolemon teolemon added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Oct 31, 2022
stephanegigandet pushed a commit that referenced this issue May 16, 2023
fix: make products aligned again in list (#7309)
Copy link
Contributor

github-actions bot commented Jan 2, 2024

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 2, 2024
@teolemon teolemon moved this to To discuss and validate in 🍊 Open Food Facts Server issues Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Design Hacktoberfest 🎨 New design Issues related to the Open Food Facts JS/CSS/HTML redesign. ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
Status: To discuss and validate
Development

Successfully merging a pull request may close this issue.

5 participants