Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show the Eco-Score on world.off.org on non-logged in users #7378

Closed
teolemon opened this issue Sep 20, 2022 · 4 comments · Fixed by #7913 or #7781
Closed

Show the Eco-Score on world.off.org on non-logged in users #7378

teolemon opened this issue Sep 20, 2022 · 4 comments · Fixed by #7913 or #7781
Assignees
@john-gom
Labels
✨ Feature Features or enhancements to Open Food Facts server 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🎯 P0 ⭐ top issue Top issue.

Comments

@teolemon
Copy link
Member

teolemon commented Sep 20, 2022 •
edited
Loading

Problem description

Most of our traffic comes from world.off.org where we don't show the Eco-Score because we don't know the core country
This is a massive lost opportunity to educate about Eco-Score and show the value of Open Food Facts

Desired solution

Show the Eco-Score on world.off.org on non-logged in users, possibly with a warning or a country refiner

Number of products impacted

100%

Mockups

image
@teolemon teolemon added the ✨ Feature Features or enhancements to Open Food Facts server label Sep 20, 2022
@teolemon teolemon added 🎯 P0 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products labels Sep 20, 2022
@github-actions github-actions bot added the ⭐ top issue Top issue. label Nov 19, 2022
@github-actions github-actions bot mentioned this issue Nov 19, 2022
Open
@john-gom
Copy link
Contributor

I'll take a look at this. Proposal is to show the "world" EcoScore with a note to say that this will be more accurate if a country is selected

@john-gom
Copy link
Contributor

First pass is available in branch issue/7378

Currently enabling in all regions with a warning in the Knowledge Panel where full information is not available. Looks like this on the web site:

image

On mobile:

image

@teolemon teolemon moved this to 🏗 In progress in 🌍 - Internationalization Dec 21, 2022
@john-gom
Copy link
Contributor

Have also updated the attribute panel to show a short warning (using the existing "missing" property):

image

This isn't implemented on mobile.

@john-gom john-gom mentioned this issue Dec 29, 2022
Merged
@john-gom
Copy link
Contributor

john-gom commented Jan 13, 2023 •
edited
Loading

Have also updated the attribute panel to show a short warning (using the existing "missing" property):

image

This isn't implemented on mobile.

This has now been reverted following PR feedback. The only warning will be on the main knowledge panel. The warning text has also been simplified to either:

Select a country in order to include the full impact of transportation.

or

The full impact of transportation to your country is currently unknown.

john-gom added a commit that referenced this issue Jan 14, 2023
@john-gom
feat: Show EcoScore attribute panel for world. Fixes #7378 (#7913)
b0f28f7 
* Remove suppression of Eco-Score but add a warning

* Test data changes (not all seem linked to my changes)

* Display a short warning in the attribute panel

* Updated test results

* Perltidy fixes

* Forgot to build_lang_test

* Changed messages as per PR feedback

* More tests affected by taxonomy changes

* more test updates after building taxonomies

* Revert changes to the sattributres panel
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in 🌍 - Internationalization Jan 14, 2023
@openfoodfacts-bot openfoodfacts-bot mentioned this issue Jan 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@john-gom john-gom

Labels
✨ Feature Features or enhancements to Open Food Facts server 🌱 Green-Score https://world.openfoodfacts.org/eco-score-the-environmental-impact-of-food-products 🎯 P0 ⭐ top issue Top issue.
Projects
🌍 - Internationalization
Status: ✅ Done
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
2 participants
@teolemon @john-gom