Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: added Quark subcategory - curd snacks #7458

Merged
merged 2 commits into from
Oct 12, 2022
Merged

taxonomy: added Quark subcategory - curd snacks #7458

merged 2 commits into from
Oct 12, 2022

Conversation

DanieliusAsm
Copy link
Contributor

What

@DanieliusAsm DanieliusAsm changed the title Taxonomy: added Quark subcategory - curd snacks taxonomy: added Quark subcategory - curd snacks Oct 8, 2022
@@ -43772,7 +43772,7 @@ ja:クワルク
ka:ხაჭო
ko:크바르크
lb:Stoffi
lt:Varškės sūris
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Varškės sūris" a correct name that we should add as a synonym?

Copy link
Contributor Author

@DanieliusAsm DanieliusAsm Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am editing taxonomies that will be in a different commit/PR where Im trying to add lithuanian category taxonomies. The current translation for en:quarks also has Grūdėta varškė which means cottage cheese. I was a bit confused since Q622563 had a synonim listed cottage cheese but then later found a sepparate category for it https://world.openfoodfacts.org/category/cottage-cheeses

Im confused on en:Quark being lt:Varškės sūris. Q259642 translates quark into it but I think that is incorrect. This cattegory is Varškės sūris or in english would translate: Lithuanian Curd(Quark) cheese

An example of such product would be this product

Copy link
Contributor Author

@DanieliusAsm DanieliusAsm Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For en:Quarks,Quark it should be lt:Varškės,Varškė

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

categories.txt.bak was added by mistake I think could you remove it?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DanieliusAsm
Copy link
Contributor Author

@stephanegigandet I deleted categories.bak not sure if you noticed it.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 9635677 into openfoodfacts:main Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants