Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add placeholder count check to check-translations.sh #7960

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

diivi
Copy link
Member

@diivi diivi commented Jan 7, 2023

What

  • Modified the check-translations.sh shell script to check if the number of placeholders in msgstr and msgid are same.

Screenshot

For en.po (no errors)
image
For aa.po (86 occurrences)
image

Related issue(s) and discussion

@diivi diivi requested a review from a team as a code owner January 7, 2023 16:07
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon added 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Jan 9, 2023
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waow really cool @diivi !

@alexgarel alexgarel merged commit b6f460e into main Jan 10, 2023
@alexgarel alexgarel deleted the feat/translation-test-check-placeholders branch January 10, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Translation test should fail on missing placeholders
3 participants