fix: remove extra barcode in product edit form #8223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
✏️ Editing
Template::Toolkit
|
Kudos, SonarCloud Quality Gate passed!
|
|
@stephanegigandet: Side effect: third party scripts are not allowed to use this code any more in the edit validation page. Power User Script is now failing to display things in this page. See @benbenben2 comment in #power-user-extension channel. IMHO, even if some Power User Script features will be soon included in Product Opener (see #8032), the barcode information should be present as an id for future third party usages. It could be everywhere. In the head, for example. But third party scripts should be able to easily find the barcode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the barcode at the top (which was previously hidden with a display:none css rule that we removed)