Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: data quality errors knowledge panel #8032

Merged
merged 28 commits into from
Apr 4, 2023
Merged

feat: data quality errors knowledge panel #8032

merged 28 commits into from
Apr 4, 2023

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Jan 24, 2023 •
edited
Loading

@github-actions github-actions bot added Display 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Jan 24, 2023
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Jan 27, 2023
@github-actions github-actions bot added Products Tags 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 unit tests labels Feb 3, 2023
@alexgarel alexgarel force-pushed the feat-quality-kp branch 2 times, most recently from 39fe9d0 to 364ac95 Compare February 8, 2023 09:27
@alexgarel alexgarel mentioned this pull request Feb 8, 2023
Merged
@github-actions github-actions bot added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Feb 14, 2023
@teolemon
Copy link
Member

@alexgarel Can you add a quick screenshot to the PR ?

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023 •
edited
Loading

Codecov Report

Merging #8032 (cf41edd) into main (bfc1fe2) will increase coverage by 0.45%.
The diff coverage is 88.17%.

@@            Coverage Diff             @@
##             main    #8032      +/-   ##
==========================================
+ Coverage   46.61%   47.06%   +0.45%     
==========================================
  Files         106      109       +3     
  Lines       20787    20972     +185     
  Branches     4696     4730      +34     
==========================================
+ Hits         9689     9871     +182     
+ Misses       9946     9937       -9     
- Partials     1152     1164      +12
Impacted Files Coverage Δ
lib/ProductOpener/Display.pm 4.72% <0.00%> (+0.04%) ⬆️
lib/ProductOpener/Products.pm 42.30% <0.00%> (-0.07%) ⬇️
lib/ProductOpener/KnowledgePanels.pm 11.72% <50.00%> (+5.47%) ⬆️
lib/ProductOpener/Test.pm 37.56% <60.00%> (+0.77%) ⬆️
lib/ProductOpener/Tags.pm 40.18% <85.33%> (+2.03%) ⬆️
lib/ProductOpener/KnowledgePanelsContribution.pm 92.85% <92.85%> (ø)
tests/unit/contribution_knowledge_panels.t 100.00% <100.00%> (ø)
tests/unit/data_quality_tags_panel.t 100.00% <100.00%> (ø)
tests/unit/tags.t 90.03% <100.00%> (+0.58%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet
Copy link
Contributor

The latest version looks very good (and very useful). :)

There are a few places where the code could be simpler I think.

@teolemon @stephanegigandet
Update po/common/common.pot
17ce75c 
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Mar 13, 2023
@CharlesNepote CharlesNepote mentioned this pull request Mar 20, 2023
Merged
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

CharlesNepote
CharlesNepote reviewed Apr 1, 2023
View reviewed changes
taxonomies/data_quality.txt Outdated Show resolved Hide resolved
taxonomies/test.txt Outdated Show resolved Hide resolved
taxonomies/test.txt Outdated Show resolved Hide resolved
templates/web/pages/product_edit/product_edit_form_process.tt.html Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Apr 3, 2023
@alexgarel @CharlesNepote
Apply suggestions from code review
5838279 
Co-authored-by: Charles Nepote <charles@nepote.org>
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Apr 4, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexgarel alexgarel merged commit 0898399 into main Apr 4, 2023
@alexgarel alexgarel deleted the feat-quality-kp branch April 4, 2023 14:20
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesNepote CharlesNepote CharlesNepote left review comments

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@alexgarel alexgarel

Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) CSS 🧽 Data quality https://wiki.openfoodfacts.org/Quality Display 🐋 Docker https://docker-curriculum.com/ ✏️ Editing icons 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 💥 Merge Conflicts 💥 Merge Conflicts Product Page Products Tags 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 🧪 unit tests
Projects
📖 Knowledge panels
Status: To do
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexgarel @teolemon @codecov-commenter @stephanegigandet @CharlesNepote