fix: new misc tags for packaging imports, + set packagings_complete #8409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Data import
📦 Packaging
Codecov Report
@@ Coverage Diff @@
## main #8409 +/- ##
=======================================
Coverage 48.44% 48.45%
=======================================
Files 113 113
Lines 21251 21260 +9
Branches 4767 4769 +2
=======================================
+ Hits 10296 10302 +6
- Misses 9674 9676 +2
- Partials 1281 1282 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alexgarel
approved these changes
May 11, 2023
| @@ -23,13 +23,11 @@ | |||
| "vegetarian" : "maybe" | |||
| }, | |||
| { | |||
| "id" : "en:basil-leaf", | |||
| "id" : "fr:feuilles-de-basilic", | |||
There was a problem hiding this comment.
do you know why we have this change ?
There was a problem hiding this comment.
My mistake, I updated the tests with a wrong version of the taxonomy.
|
Kudos, SonarCloud Quality Gate passed!
|
teolemon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates new fields for the number of packaging components (in particular to ease debugging of packagings imports from producers).
When we get packagings imported from producers, it also sets the packagings_complete field to 1.