Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make products aligned again in list #7309 #8423

Merged
merged 1 commit into from
May 16, 2023

Conversation

jusfla
Copy link
Contributor

@jusfla jusfla commented May 16, 2023

What

Fix the alignments of products at the beginning and the end of the list of products so as to make it more aesthetically coherent with the whole list and new app design.

Screenshot

E43CAE7F-480C-460C-9DF2-62EED5949E6E

Screenshot 2023-05-16 at 14 36 50

Related issue(s) and discussion

@jusfla jusfla requested a review from a team as a code owner May 16, 2023 12:44
@github-actions github-actions bot added the CSS label May 16, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #8423 (6ad84e2) into main (9d29232) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8423   +/-   ##
=======================================
  Coverage   48.51%   48.51%           
=======================================
  Files         114      114           
  Lines       21294    21294           
  Branches     4773     4773           
=======================================
  Hits        10330    10330           
  Misses       9679     9679           
  Partials     1285     1285           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @jusfla! I tested it, it is working very well with all the different screen sizes.

There's one issue when the last line has more than 1 entry but is missing 2 or more entries to get a full line, but it's probably a different bug that we can fix in another PR.

@stephanegigandet
Copy link
Contributor

Probably a different issue: the last line looks funny when there is more than 1 product, but it is missing more than 1 product.

Missing 1 product looks fine:

image

Missing 2 products:

image

Missing 3 products:

image

@stephanegigandet stephanegigandet merged commit cf700f0 into main May 16, 2023
@stephanegigandet stephanegigandet deleted the fix-list-products-not-aligned branch May 16, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEW DESIGN: products not aligned on first row and last row of lists of products
3 participants