Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: app landing page improvements #9001

Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix: app landing page improvements #9001

merged 3 commits into from
Sep 18, 2023

Conversation

raphael0202
Copy link
Contributor

Everything is related to app landing page.

@raphael0202
fix: CSS improvements
9690840 
- remove shadow on text highlights
- remove font ligature on Plus Jakarta Sans
@raphael0202
fix: add an id to top mobile banner
3a189dd 
so that we can hide it easily on app page
@raphael0202
fix: fix app landing page detection for French
3f15def
@raphael0202 raphael0202 requested a review from a team as a code owner September 14, 2023 11:15
@raphael0202 raphael0202 changed the title Front improvements fix: app landing page improvements Sep 14, 2023
@github-actions github-actions bot added product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements CSS Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Display labels Sep 14, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

stephanegigandet
stephanegigandet approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@raphael0202 raphael0202 merged commit 5ed5f84 into main Sep 18, 2023
@raphael0202 raphael0202 deleted the front-improvements branch September 18, 2023 08:02
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Sep 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

@teolemon teolemon Awaiting requested review from teolemon

Assignees

@raphael0202 raphael0202

Labels
CSS Display product history We have kept 10 years of product revisions. This is useful to monitor edits & product improvements Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael0202 @stephanegigandet