Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app landing page improvements #9001

Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix: app landing page improvements #9001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9690840
fix: CSS improvements
raphael0202 Sep 14, 2023
3a189dd
fix: add an id to top mobile banner
raphael0202 Sep 14, 2023
3f15def
fix: fix app landing page detection for French
raphael0202 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ProductOpener/Display.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ sub display_text ($request_ref) {

$request_ref->{page_type} = "text";

if ($textid eq 'open-food-facts-mobile-app') {
if ($textid =~ /open-food-facts-mobile-app|application-mobile-open-food-facts/) {
# we want the mobile app landing page to be included in a <div class="row">
# so we display it under the `banner` page format, which is the page format
# used on product pages, with a colored banner on top
Expand Down
3 changes: 2 additions & 1 deletion scss/_off.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1416,6 +1416,7 @@ $section-cyan: #008c8c;
font-weight: 700;
// override color as it is not black due to our choice of $dark
color: $black !important;
font-variant-ligatures: none;
}


Expand All @@ -1429,7 +1430,6 @@ $section-cyan: #008c8c;
border-radius: 5px;
text-transform: uppercase;
display: inline-block;
box-shadow: 0px 4px 4px 0px rgba(0, 0, 0, 0.25);

&.orange {
background-color: $off-orange;
Expand Down Expand Up @@ -1641,6 +1641,7 @@ a.panel_title {
#app-landing-page {
// use Plus Jakarta Sans everywhere
font-family: "Plus Jakarta Sans", $font-family-sans-serif;
font-variant-ligatures: none;

.highlight-label {
// make the highlighted labels smaller
Expand Down
2 changes: 1 addition & 1 deletion templates/web/common/site_layout.tt.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@
<!-- full width banner on mobile -->

[% IF mobile %]
<a href="[% mobile.link %]" class="button large expand success">
<a href="[% mobile.link %]" id="mobile-app-top-banner" class="button large expand success">
<div class="row collapse">
<div class="small-6 columns">
[% mobile.text %]
Expand Down