-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: have two apache servers #10766
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you.
I added a few comments, I think we should at least add the HEAD/OPTIONS/PATCH methods (or maybe just remove the method altogether, I can't think of a case where we would want to send a request to different Apache servers based on the method)
Also unify port number to 8001
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #10766 +/- ##
==========================================
+ Coverage 49.22% 49.25% +0.03%
==========================================
Files 78 78
Lines 22405 22418 +13
Branches 5374 5372 -2
==========================================
+ Hits 11028 11043 +15
+ Misses 10020 10019 -1
+ Partials 1357 1356 -1 ☔ View full report in Codecov by Sentry. |
moving logic to a specific envvar files.
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
Quality Gate passedIssues Measures |
See openfoodfacts/openfoodfacts-infrastructure#399
Part of: