Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: have two apache servers #10766

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

chore: have two apache servers #10766

wants to merge 20 commits into from

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Sep 3, 2024

@alexgarel alexgarel requested a review from a team as a code owner September 3, 2024 16:18
@alexgarel alexgarel marked this pull request as draft September 3, 2024 16:18
@github-actions github-actions bot added the 🪶 Apache We use Apache as a server to run Open Food Facts label Sep 3, 2024
env/env.obf.main Outdated Show resolved Hide resolved
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

I added a few comments, I think we should at least add the HEAD/OPTIONS/PATCH methods (or maybe just remove the method altogether, I can't think of a case where we would want to send a request to different Apache servers based on the method)

Also unify port number to 8001
@alexgarel alexgarel marked this pull request as ready for review September 4, 2024 21:26
@github-actions github-actions bot added 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org labels Sep 4, 2024
Copy link

sonarqubecloud bot commented Sep 6, 2024

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 18, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.25%. Comparing base (d996a33) to head (42a8e73).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10766      +/-   ##
==========================================
+ Coverage   49.22%   49.25%   +0.03%     
==========================================
  Files          78       78              
  Lines       22405    22418      +13     
  Branches     5374     5372       -2     
==========================================
+ Hits        11028    11043      +15     
+ Misses      10020    10019       -1     
+ Partials     1357     1356       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Jan 7, 2025
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@github-actions github-actions bot added the GitHub Actions Pull requests that update Github_actions code label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪶 Apache We use Apache as a server to run Open Food Facts GitHub Actions Pull requests that update Github_actions code NGINX 🧴 Open Beauty Facts Our cosmetic analysis project https://world.openbeautyfacts.org 🐾 Open Pet Food Facts Our pet food analysis project https://world.openpetfoodfacts.org 📸 Open Products Facts Our project to increase the lifespan of objects. https://world.openproductsfacts.org systemd
Projects
Status: In progress
Status: Review in progress
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants