fix: downgrade jquery-ui #10877
Merged
fix: downgrade jquery-ui #10877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
dependencies
hangy
reviewed
Oct 11, 2024
|
@hangy When building js files locally after downgrading jquery-ui version, @Valimp encountered issues with typescript compilation. Now we will try to downgrade only jquery-ui. |
|
stephanegigandet
pushed a commit
that referenced
this pull request
Oct 18, 2024
🤖 I have created a release *beep* *boop* --- ## [2.46.0](v2.45.0...v2.46.0) (2024-10-18) ### Features * upload DB dump to AWS S3 ([#10863](#10863)) ([34ae5e4](34ae5e4)) ### Bug Fixes * docs (paragraph 24) ([#10849](#10849)) ([354c22c](354c22c)) * docs fix a broken Internal URL to Open Prices ([#10852](#10852)) ([d318472](d318472)) * docs Syntax issues ([#10851](#10851)) ([56275c4](56275c4)) * downgrade jquery-ui ([#10877](#10877)) ([2cd6fd5](2cd6fd5)) * In the Folksonomy Engine table, property and value headers were not at the right place ([#10857](#10857)) ([7547657](7547657)) * remove off days banner ([#10908](#10908)) ([855ae0c](855ae0c)) * update paths for EAN8 and short barcodes (padding with zeroes) - DO NOT MERGE ([#10472](#10472)) ([3c18781](3c18781)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
stephanegigandet
pushed a commit
that referenced
this pull request
Oct 23, 2024
…10708)" (#10924) This reverts commit 9407e86. <!-- IMPORTANT CHECKLIST Make sure you've done all the following (You can delete the checklist before submitting) - [x] PR title is prefixed by one of the following: feat, fix, docs, style, refactor, test, build, ci, chore, revert, l10n, taxonomy - [ ] ~~Code is well documented~~ - [ ] ~~Include unit tests for new functionality~~ - [ ] Code passes GitHub workflow checks in your branch - [ ] ~~If you have multiple commits please combine them into one commit by squashing them.~~ - [x] Read and understood the [contribution guidelines](https://github.com/openfoodfacts/openfoodfacts-server/blob/main/CONTRIBUTING.md) --> ### What After replicating the nutrient autosuggest selection problem (one of a few JavaScript-related problems) described in #10861 in a local development instance, I attempted a revert of #10708 because the name of the dependency seems similar to a missing function that appeared in the JavaScript console as an error: ``` Uncaught TypeError: e.ui.safeActiveElement is not a function ``` After reverting #10708, the error no longer appears and I'm able to select entries from the nutrient autosuggest as expected. ### Screenshot https://github.com/user-attachments/assets/eb40f7dd-3167-4c0b-a982-9bc46db06988 ### Related issue(s) and discussion - Fixes #10861 (in combination with #10877).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Downgrade jquery-ui to 1.13.3 instead of 1.14.0