Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display of usage in scripts/import_csv_file.pl #11086

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

dolmen
Copy link
Collaborator

@dolmen dolmen commented Dec 3, 2024

What

Fix typo that blocked display of usage message in case of incorrect options.

(Hackathon des Données Alimentaires)

@dolmen dolmen requested a review from a team as a code owner December 3, 2024 10:14
@dolmen dolmen added file import Perl Related to the Perl code of the ProductOpener server labels Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.98%. Comparing base (dc04d18) to head (8fe02f0).
Report is 811 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11086      +/-   ##
==========================================
- Coverage   49.54%   48.98%   -0.56%     
==========================================
  Files          67       78      +11     
  Lines       20650    22300    +1650     
  Branches     4980     5340     +360     
==========================================
+ Hits        10231    10924     +693     
- Misses       9131    10041     +910     
- Partials     1288     1335      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dolmen !

@stephanegigandet
Copy link
Contributor

/update_tests_results

Fix typo that blocked display of usage message in case of incorrect options.
@dolmen dolmen force-pushed the fix/import_csv_file-usage branch from 9c860f4 to 8fe02f0 Compare December 9, 2024 14:21
@github-actions github-actions bot added the 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers label Dec 9, 2024
Copy link

sonarqubecloud bot commented Dec 9, 2024

@dolmen dolmen merged commit 2948d82 into openfoodfacts:main Dec 9, 2024
14 checks passed
alexgarel pushed a commit that referenced this pull request Dec 10, 2024
Trying to get the tests to pass for
#11086

Co-authored-by: Olivier Mengué <dolmen@cpan.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
file import Perl Related to the Perl code of the ProductOpener server 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants