Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: additives table + clean HTML to remove some validation errors #11093

Merged
merged 4 commits into from
Dec 9, 2024
Merged

fix: additives table + clean HTML to remove some validation errors #11093

merged 4 commits into from
Dec 9, 2024

Conversation

stephanegigandet
Copy link
Contributor

in pagination
  • removes some HTML errors
  • moves Matomo script in the body instead of the head as it contains a noscript tag with an image for users that don't have JS
    •

    @stephanegigandet stephanegigandet requested a review from a team as a code owner December 6, 2024 10:19
    @github-actions github-actions bot added Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🎁 donations Display Site layout labels Dec 6, 2024
    @sonarqubecloud SonarQubeCloud
    Copy link

    sonarqubecloud bot commented Dec 6, 2024

    Quality Gate Passed Quality Gate passed

    Issues
    0 New issues
    0 Accepted issues

    Measures
    0 Security Hotspots
    0.0% Coverage on New Code
    0.0% Duplication on New Code

    See analysis details on SonarQube Cloud

    @stephanegigandet stephanegigandet merged commit 474f68d into main Dec 9, 2024
    14 checks passed
    @stephanegigandet stephanegigandet deleted the fix-additives-table branch December 9, 2024 14:12
    @openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 9, 2024
    Merged
    stephanegigandet pushed a commit that referenced this pull request Dec 11, 2024
    @openfoodfacts-bot
    chore(main): release 2.51.0 (#11066)
    455f552 
    🤖 I have created a release *beep* *boop*
---


##
[2.51.0](v2.50.0...v2.51.0)
(2024-12-10)


### Features

* Add script to remove nearly empty products with quality issues
([#11058](#11058))
([82726d5](82726d5))
* NOVA 4 attribute and knowledge panel improvements
([#11035](#11035))
([9048011](9048011))


### Bug Fixes

* additives table + clean HTML to remove some validation errors
([#11093](#11093))
([474f68d](474f68d))
* avoid crash if ingredients services called without ingredients_lc
([#11055](#11055))
([1db3e94](1db3e94))
* data quality, false positive, nutrition sum with lower symbol
([#11076](#11076))
([d389c87](d389c87))
* data quality, false positive, nutrition sum with lower symbol for milk
below the table
([#11098](#11098))
([7febb69](7febb69))
* display of usage in scripts/import_csv_file.pl
([#11091](#11091))
([91881f8](91881f8))
* improve parsing of 'category (type 1, type 2..)' ingredients
([#10999](#10999))
([42618ac](42618ac))
* letter A at end of string is not a stopword
([#11095](#11095))
([6eaeb26](6eaeb26))
* Load products in mongodb
([#11072](#11072))
([6787ba1](6787ba1))
* new images path
([#11096](#11096))
([8658959](8658959))
* pro platform product writes to the public platform MongoDB database
([#11065](#11065))
([f77eb82](f77eb82))
* product image move
[#11067](#11067)
([#11092](#11092))
([30257c1](30257c1))
* remove warning in ecobalyse matching of ingredients
([#11062](#11062))
([c29fce9](c29fce9))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @teolemon teolemon teolemon approved these changes

    Assignees

    @stephanegigandet stephanegigandet

    Labels
    Display 🎁 donations Site layout Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🧪 unit tests
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    Incorrect column count in additives facet page
    2 participants
    @stephanegigandet @teolemon