feat: new import_images.pl script for pro platform #11225
Merged
+576
−275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Data import
🖼️ Images
🏭 Producers Platform
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #11225 +/- ##
==========================================
+ Coverage 49.22% 49.33% +0.11%
==========================================
Files 78 79 +1
Lines 22405 22506 +101
Branches 5374 5386 +12
==========================================
+ Hits 11028 11104 +76
- Misses 10020 10042 +22
- Partials 1357 1360 +3 ☔ View full report in Codecov by Sentry. |
teolemon
reviewed
Jan 10, 2025
Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org>
alexgarel
approved these changes
Jan 20, 2025
Comment on lines
+2791
to
+2794
| upload_images_for_product( | ||
| $args_ref, $images_ref->{$code}, $product_ref, $imported_product_ref, $product_id, | ||
| $code, $user_id, $product_comment, $stats_ref | ||
| ); |
Co-authored-by: Alex Garel <alex@openfoodfacts.org>
Co-authored-by: Alex Garel <alex@openfoodfacts.org>
Co-authored-by: Alex Garel <alex@openfoodfacts.org>
|
stephanegigandet
pushed a commit
that referenced
this pull request
Jan 22, 2025
🤖 I have created a release *beep* *boop* --- ## [2.56.0](v2.55.0...v2.56.0) (2025-01-22) ### Features * add common categories found on re-commerce websites ([#11263](#11263)) ([8f54f80](8f54f80)) * Add common cosmetic allegations ([#11264](#11264)) ([94de6d0](94de6d0)) * add link on pro platform to see nutriscore evolution [#11246](#11246) ([#11247](#11247)) ([c0518c1](c0518c1)) * new import_images.pl script for pro platform ([#11225](#11225)) ([a46c967](a46c967)) * Update the tagline to force the app upgrade ([#11262](#11262)) ([f685cb0](f685cb0)) ### Bug Fixes * Add more german stopwords ([#11266](#11266)) ([4e45a34](4e45a34)) * link of nutri-score knowledge panel on pro platform ([#11272](#11272)) ([75a873b](75a873b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The import of images in the pro platform is currently tied to the import of product data: we import images only of they come with product data.
Some producers can send us product photos in bulk, without sending product data at the same time.
The new image_import.pl script is to load those photos. The script essentially uses existing code from Import.pm (which has been moved a bit in separate functions).