Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refreshed english translations #2336

Merged
merged 6 commits into from
Sep 25, 2019
Merged

Refreshed english translations #2336

merged 6 commits into from
Sep 25, 2019

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Sep 16, 2019 •
edited
Loading

The en.po had fallen behind common.pot because no export is done, unlike for en_au.po

@teolemon
en-us from en-au
0237f2f 
en-us from en-au
stephanegigandet
stephanegigandet reviewed Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
stephanegigandet
stephanegigandet reviewed Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
stephanegigandet
stephanegigandet reviewed Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
stephanegigandet
stephanegigandet reviewed Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
@stephanegigandet
Copy link
Contributor

There are many missing translations, and a few bad ones.

@teolemon
Copy link
Member Author

The missing translations: This is English, so it doesn't matter much at the end of the day.
Bad ones: separate PR

teolemon
teolemon commented Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 16, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 17, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 17, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 17, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 17, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
teolemon
teolemon commented Sep 17, 2019
View reviewed changes
po/common/en.po Outdated Show resolved Hide resolved
@stephanegigandet
Copy link
Contributor

"en-us from en-au" --> what does that mean?

@teolemon
Copy link
Member Author

I used the en-au file to create this file. It doesn't matter much actually.

@teolemon teolemon changed the title en-us from en-au Refreshed english translations Sep 17, 2019
@teolemon
Copy link
Member Author 

Testing po/common/en.po .po fileError: empty msgstr string for msgctxt add_user_email_body - msgid 
Error: empty msgstr string for msgctxt licence_accept - msgid 
Error: empty msgstr string for msgctxt login_register_content - msgid 
Error: empty msgstr string for msgctxt login_to_add_products - msgid 
Error: empty msgstr string for msgctxt nutrition_data_table_note - msgid 
Error: empty msgstr string for msgctxt openfoodhunt_points - msgid 
Error: empty msgstr string for msgctxt reset_password_email_body - msgid 
Error: empty msgstr string for msgctxt search_graph_instructions - msgid 
Error: empty msgstr string for msgctxt warning_3rd_party_content - msgid

@teolemon teolemon merged commit 0c5567f into master Sep 25, 2019
@teolemon teolemon deleted the en-us-from-en-au branch September 25, 2019 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teolemon @stephanegigandet