Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make maybe vegan/vegetarian/palm-oil free attribute score 50 instead of 20 #5839

Merged
merged 1 commit into from
Oct 6, 2021

Conversation

stephanegigandet
Copy link
Contributor

When all the ingredients of a product are known in the ingredients taxonomy, and all of them have the vegan:en:yes property or a vegan:en:maybe (when an ingredient can be either vegan or not), the product is marked as maybe vegan.

This is to change the vegan attribute match value from 20 to 50 in that case, so that clients that have 3 settings for attributes (e.g. the next version of the Flutter app) can display them with the 2nd setting (e.g. "orange" color if there are 3 colors red / orange / green).

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 70ea2e1 into main Oct 6, 2021
@stephanegigandet stephanegigandet deleted the attributes branch October 6, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants