feat: dynamic assets generation in dev mode #5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgarel
force-pushed
the
ag-feat-dev-dynamic-assets
branch
from
4d9504c to
ee398e6
Compare
astagi
requested changes
Oct 7, 2021
alexgarel
force-pushed
the
ag-feat-dev-dynamic-assets
branch
from
ee398e6 to
b11b7f7
Compare
alexgarel
force-pushed
the
ag-feat-dev-dynamic-assets
branch
from
b11b7f7 to
2ecd558
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@astagi I even make it easy to run those checks before committing ;-) |
|
Any one to finish review this @astagi or @stephanegigandet ? |
stephanegigandet
approved these changes
Oct 12, 2021
|
@astagi it seems your approval is required since you requested changes ! |
|
Sorry for my late response@alexgarel lgtm!! |
astagi
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Make dev life more easy by reinstalling nodejs modules at startup (avoid removing / recreating node modules volume) and rebuilding and watching assets
Related issues and discussion: #5846