Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nutri-Score panel, add reason when not computed #6237

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Jan 3, 2022

The Nutri-Score panel currently has a broken image when the Nutri-Score is unknown.

This fixes it, and also displays in the panel subtitle the reason why the Nutri-Score is not computed: missing category, not applicable category, or missing nutrition data.

Also moved the Nutri-Score warnings for fiber and fruits inside the Nutri-Score panel.

Part of

@stephanegigandet stephanegigandet added 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels labels Jan 3, 2022
@stephanegigandet stephanegigandet requested a review from a team as a code owner January 3, 2022 18:52
@stephanegigandet
Copy link
Contributor Author

image

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + tested ok

@alexgarel alexgarel merged commit d260e99 into main Jan 4, 2022
@alexgarel alexgarel deleted the nutriscore-panel branch January 4, 2022 18:15
@teolemon teolemon added 🚦 Nutri-Score and removed 🚦Nutri-Score https://world.openfoodfacts.org/nutriscore labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🚦 Nutri-Score
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants