feat: Fix and improve detection of apps (name and UUID) to populate data sources #6319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Display
🧪 tests
Translations
teolemon
approved these changes
Jan 20, 2022
|
Did you update the documentation to explain the new parameters ? I think you should update the wiki and the API documentation. |
|
Kudos, SonarCloud Quality Gate passed!
|
VaiTon
reviewed
Jan 26, 2022
Comment on lines
+1110
to
+1116
| # Allow apps to send app_name, app_version and app_uuid parameters | ||
| foreach my $field (qw(app_name app_version app_uuid)) { | ||
| my $value = remove_tags_and_quote(decode utf8=>param($field)); | ||
| if ((defined $value) and ($value ne "")) { | ||
| $change_ref->{$field} = $value; | ||
| } | ||
| } |
There was a problem hiding this comment.
So we have three string parameters:
app_nameapp_versionapp_uuid
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to identifiy product edits that are made through apps, so that we can populate the data_sources facet. We currently do it by using the comment field that can contain an app name, and in some cases a uuid (used so that we can group contributions by the same user, for instance to check for errors), and/or the specific OFF user used by some app. This has been broken for some time.
This PR: