Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: URL linked to $request_ref->{world_current_link} & $world_subdomain #6669

Merged
merged 9 commits into from
May 12, 2022
Merged

fix: URL linked to $request_ref->{world_current_link} & $world_subdomain #6669

merged 9 commits into from
May 12, 2022

Conversation

pradumna-gautam
Copy link
Contributor

Description

Fix #1437
Changed the URL linked to $request_ref->{world_current_link}
and $world_subdomain in file Display.pm

Related issue(s) and discussion

@pradumna-gautam pradumna-gautam requested a review from a team as a code owner April 22, 2022 14:52
@pradumna-gautam
Copy link
Contributor Author

I'm thinking of solving this issue this way:-
We can have a sub 'get_world_subdomain' instead of using a variable, and everywhere we use $world_subdomain, we can replace it with a function call.
So, I wrote the sub like this, and called the function as follows:-
$get_world_subdomain()
Is this approach correct?
Also, I replaced all $world_subdomain with $get_world_subdomain in [Display.pm]

alexgarel
alexgarel requested changes May 10, 2022
View reviewed changes
lib/ProductOpener/Display.pm Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

stephanegigandet
stephanegigandet approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@pradumna-gautam pradumna-gautam requested a review from alexgarel May 12, 2022 10:22
alexgarel
alexgarel approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexgarel alexgarel merged commit 13c725e into openfoodfacts:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@pradumna-gautam pradumna-gautam

Labels
None yet
Projects
old prs
Status: No status
🍊 Open Food Facts Server issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep the same UI language after clicking showing products from the whole world
3 participants
@pradumna-gautam @alexgarel @stephanegigandet