Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Untranslated string fixed and now translatable to any language #6666 #6670

Merged
merged 5 commits into from
Apr 22, 2022

Conversation

pradumna-gautam
Copy link
Contributor

###Description
Fixed #6629
Fixed the string which was not translatable i.e. "Impact for this product"
And change the following files:-
po/common/common.pot
po/common/en.po
templates/api/knowledge-panels/environment/ecoscore/total.tt.json

###Screenshot
163581428-72322440-adbb-45df-8f84-3d4441d49ad2

###Related issue(s) and discussion
Fixes #6629

@pradumna-gautam pradumna-gautam requested a review from a team as a code owner April 22, 2022 15:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good :-)

@alexgarel alexgarel merged commit 13a571c into openfoodfacts:main Apr 22, 2022
@pradumna-gautam
Copy link
Contributor Author

Good :-)

Thank You so much @alexgarel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Untranslated string: "Impact for this product"
2 participants