Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bulgarian additions #6918

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

Roto15
Copy link
Contributor

@Roto15 Roto15 commented Jun 18, 2022

No description provided.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Roto15 Roto15 added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Jun 18, 2022
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor suggestion.

@@ -30439,8 +30441,6 @@ carbon_footprint_fr_foodges_ingredient:fr:Eau en bouteille PET, plate, 0.5 L
carbon_footprint_fr_foodges_value:fr:0.4

<en:water
bg:drinking water
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add en:drinking water? We should try to always have a translation in English.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually en:water, drinking water exists already and fr:eau potable remains alone in this case.Maybe is better if I move "eau potable" next to eau like it is in english?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, "eau potable" should be a synonym of water

@stephanegigandet stephanegigandet merged commit 798a709 into openfoodfacts:main Jun 22, 2022
@Roto15 Roto15 deleted the Bulgarian-additions branch August 9, 2022 15:59
@teolemon teolemon added the 🇧🇬 Bulgaria https://bg.openfoodfacts.org label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇧🇬 Bulgaria https://bg.openfoodfacts.org 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants