Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more fields in CSV (issue 2325) #7570

Merged
merged 7 commits into from
Oct 19, 2022
Merged

feat: more fields in CSV (issue 2325) #7570

merged 7 commits into from
Oct 19, 2022

Conversation

CharlesNepote
Copy link
Member

@CharlesNepote CharlesNepote commented Oct 18, 2022 •
edited
Loading

What

CSV refactoring

  • documentation refactoring + .md file
  • added:
    • ingredients_analysis_tags
    • additives_tags
    • nutrient_levels_tags
    • product_quantity
    • owner
    • data_quality_errors_tags
    • unique_scans_n
    • popularity_tags
    • completeness
    • last_image_t

Related issue(s) and discussion

@CharlesNepote
CSV refactoring
a48e50c 
- documentation refactoring + .md file
- added:
  - ingredients_analysis_tags
  - additives_tags
  - nutrient_levels_tags
  - product_quantity
  - owner
  - data_quality_errors_tags
  - unique_scans_n
  - popularity_tags
  - completeness
  - last_image_t
- deleted: additives
@CharlesNepote
Typo
62f84a4
@CharlesNepote CharlesNepote requested a review from a team as a code owner October 18, 2022 13:00
@CharlesNepote CharlesNepote changed the title Issue 2325 feat: more fields in CSV (issue 2325) Oct 18, 2022
stephanegigandet
stephanegigandet approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should fix the field names for nutrients that have a leading dash. It's a bug and it has no meaning.
What happened is that some fields had 1 or 2 leading dashes, and we just removed the first one. We should remove both.

@CharlesNepote @stephanegigandet
Serving size doc
0577718 
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
CharlesNepote and others added 2 commits October 19, 2022 10:25
@CharlesNepote @stephanegigandet
Serving quantity doc
c182a53 
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
@CharlesNepote
Serving_size and serving_quantity docs
62dff36
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

1 similar comment
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@CharlesNepote CharlesNepote merged commit 97957e1 into main Oct 19, 2022
@CharlesNepote CharlesNepote deleted the issue-2325 branch October 19, 2022 09:09
@alexgarel alexgarel mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@CharlesNepote CharlesNepote

Labels
config exports
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CharlesNepote @stephanegigandet