Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chocolate eggs #7809

Merged
merged 1 commit into from
Dec 12, 2022
Merged

fix: chocolate eggs #7809

merged 1 commit into from
Dec 12, 2022

Conversation

moon-rabbitOFF
Copy link
Contributor

No description provided.

@github-actions github-actions bot added categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Dec 6, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet changed the title correction chocolate eggs fix: chocolate eggs Dec 8, 2022
@@ -34259,8 +34259,8 @@ wikidata:en:Q2164820
agribalyse_proxy_food_code:en:31004
#all agribalyse milk chocolate categories have the same CO2 score


<en:Chocolates
#Do not put this category under chocolates since "filled chocolate eggs" are bonbons, not chocolate
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So shouldn't it be under https://world.openfoodfacts.org/category/chocolate-candies or bonbons?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because the category "Chocolate eggs" also contains "Hollow chocolate eggs" which is in "Chocolates" and not "Bonbons"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, that's tricky.

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit f23c75b into main Dec 12, 2022
@stephanegigandet stephanegigandet deleted the corr-filled-chocolate-eggs branch December 12, 2022 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants