-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update logo of the label V-label #8247
Conversation
You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab. |
Hi @thestarsahil thank you for your PR. Did you tested it ? I don't think it will work, as stated in the issue:
By the way, if after suceeding you want to add a "how to add a label image" in the docs/ folder, you are more than welcome :-) |
@alexgarel yes i tested its working on and Sure, I'll add a guide on how to add a label image to the docs folder after successfully completing the task. Thank you for the suggestion! |
@alexgarel Can you please review this pull request? |
2 logos for the vegetarian label : Végétarien → French Vegetarian → English
Kudos, SonarCloud Quality Gate passed! |
Hi @thestarsahil. Few comments from my side, I hope it will help. You added the images in "html/images/lang/hr/" where "hr" is for Croatian. Here are some references that may guide you: wiki doc: Here is an example how-to-add-labels: Remark that there is already a logo for european-vegetarian-union: https://world.openfoodfacts.dev/label/european-vegetarian-union |
Meanwhile, I just realized that your PR @thestarsahil is related to this issue: Fixes #8214. So, we can ignore my last remark :) You will have to (replace <> by appropriate number and file extension everywhere):
Curiously, for French, it is now showing the English version: https://fr.openfoodfacts.dev/label/european-vegetarian-union-vegetarian That is how others labels seems to be done, see for example with PDO and AOP: You can test it during your dev. |
@thestarsahil do you think you will have time to continue this PR ? |
@alexgarel yes I can |
2 logos for the vegetarian label :
Végétarien → French
Vegetarian → English
What
Screenshot
Related issue(s) and discussion