Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Week 11 (or so) taxonomy updates #8256

Merged
merged 63 commits into from
Apr 14, 2023
Merged

chore: Week 11 (or so) taxonomy updates #8256

merged 63 commits into from
Apr 14, 2023

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Mar 26, 2023

What

Continued work on taxonomies #8253

@github-actions github-actions bot added categories 🥗 Ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Mar 26, 2023
@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2023

Codecov Report

Merging #8256 (f754cce) into main (28aa93d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8256   +/-   ##
=======================================
  Coverage   48.14%   48.14%           
=======================================
  Files         109      109           
  Lines       21008    21008           
  Branches     4739     4739           
=======================================
  Hits        10115    10115           
  Misses       9618     9618           
  Partials     1275     1275           
Impacted Files Coverage Δ
tests/unit/tags.t 90.03% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Mar 28, 2023
@github-actions github-actions bot added 💥 Merge Conflicts 💥 Merge Conflicts and removed 💥 Merge Conflicts 💥 Merge Conflicts labels Mar 30, 2023
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I propose some small changes.

taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Apr 3, 2023
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label Apr 12, 2023
es:Ecológico, ecológica, Producto ecológico, Biológico, Producto biológico, Orgánico, Producto orgánico, Eco, Bio, Ingredientes ecológicos, Ingrediente ecológico, ingredientes procedentes de la agricultura ecológica, ingrediente procedente de la agricultura ecológica, agricultura ecológica, cumple con el reglamento de agricultura ecológica CE 2092/91, procedentes de la agricultura ecológica, procedente de la agricultura ecológica,de agricultura ecológica,de agricultura ecologica, Procedente e agricultura ecológica
de:Bio, Öko, biologisch, biologische, biologischer, biologisches, Ökologisch, Kontrolliert biologisch, Kontrolliert ökologisch, biologische Landwirtschaft, ökologische Landwirtschaft, biologischer Landbau, ökologischer Landbau, aus kontrolliert biologischem Anbau, biologisch gewonnen, aus kontrolliert biologischer landwirtschaft, aus kontrolliert ökologischer erzeugung, aus kontrolliert ökologischer landwirtschaft, aus kontrolliert ökologischem anbau, aus kontrolliert ökologischem landbau, aus kontrollierter biologischer landwirtschaft, aus kontrollierter ökologischer landwirtschaft, kontrolliert biologischer anbau
es:Ecológico, ecológica, Producto ecológico, Biológico, Producto biológico, Orgánico, Producto orgánico, Eco, Bio, Ingredientes ecológicos, Ingrediente ecológico, ingredientes procedentes de la agricultura ecológica, ingrediente procedente de la agricultura ecológica, agricultura ecológica, cumple con el reglamento de agricultura ecológica CE 2092/91, procedentes de la agricultura ecológica, procedente de la agricultura ecológica,de agricultura ecológica,de agricultura ecologica, Procedente e agricultura ecológica, de cultivo ecológico

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra line feed here that separates the organic label into 2 entries.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aleene aleene merged commit 2264a8e into main Apr 14, 2023
@aleene aleene deleted the aleene-week11 branch April 14, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants