Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export packaging components data #8362

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Conversation

stephanegigandet
Copy link
Contributor

Fixes #8361

Generate a new CSV file for packaging data, 1 line per packaging component

@stephanegigandet stephanegigandet requested a review from a team as a code owner April 25, 2023 15:03
@github-actions github-actions bot added the 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling label Apr 25, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -365,13 +406,38 @@ ($name, $query_ref)

my $packagings_stats_ref = {};

# Export packaging components of all products to a CSV file
my $filehandle;
my $filename = "$www_root/data/$name.csv";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we export to a csv.gz ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could.. but it's just a one off at this point, so that we have data for the report of the packaging operation.

@stephanegigandet stephanegigandet merged commit c84cee3 into main Apr 25, 2023
@stephanegigandet stephanegigandet deleted the export-packagings-csv branch April 25, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export packaging components data in dedicated CSV export
2 participants