Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove warning in get_inherited_property_from_categories_tags #8531

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

stephanegigandet
Copy link
Contributor

This removes a warning caused by calling lc() on something that can be undefined.

@stephanegigandet stephanegigandet requested a review from a team as a code owner June 6, 2023 16:38
@github-actions github-actions bot added 🧽 Data quality https://wiki.openfoodfacts.org/Quality Tags labels Jun 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8531 (593ac66) into main (f2f9086) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #8531   +/-   ##
=======================================
  Coverage   48.72%   48.72%           
=======================================
  Files         114      114           
  Lines       21361    21361           
  Branches     4784     4784           
=======================================
  Hits        10408    10408           
  Misses       9669     9669           
  Partials     1284     1284           
Impacted Files Coverage Δ
lib/ProductOpener/DataQualityFood.pm 63.03% <100.00%> (ø)
lib/ProductOpener/Tags.pm 40.98% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stephanegigandet stephanegigandet merged commit 783364b into main Jun 8, 2023
@stephanegigandet stephanegigandet deleted the tags-warning branch June 8, 2023 07:50
MonalikaPatnaik pushed a commit to aadak99/openfoodfacts-server that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality Tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants