Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Data::Table by Text::CSV in hr-packagers-refresh.pl #8932

Closed
wants to merge 9 commits into from

Conversation

stephanegigandet
Copy link
Contributor

write the CSV file with Text::CSV so that we don't need to install Data::Table

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2023

Codecov Report

Merging #8932 (17a7cc0) into feat_add_hr_packager_codes (d631a65) will decrease coverage by 0.47%.
The diff coverage is n/a.

@@                      Coverage Diff                       @@
##           feat_add_hr_packager_codes    #8932      +/-   ##
==============================================================
- Coverage                       46.00%   45.53%   -0.47%     
==============================================================
  Files                              64       64              
  Lines                           19783    19521     -262     
  Branches                         4790     4739      -51     
==============================================================
- Hits                             9101     8889     -212     
+ Misses                           9497     9456      -41     
+ Partials                         1185     1176       -9     
Files Changed Coverage Δ
lib/ProductOpener/Display.pm 11.27% <ø> (+0.01%) ⬆️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2 benbenben2 force-pushed the feat_add_hr_packager_codes branch from e2d2236 to 3e4532c Compare September 1, 2023 20:18
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label Sep 2, 2023
@alexgarel
Copy link
Member

@benbenben2 and @stephanegigandet is this PR to be closed ?

Base automatically changed from feat_add_hr_packager_codes to main September 5, 2023 07:28
@stephanegigandet
Copy link
Contributor Author

stephanegigandet commented Sep 5, 2023

@stephanegigandet stephanegigandet deleted the feat_add_hr_packager_codes-2 branch September 5, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants