feat: support percentage range #9224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
🧪 tests
🥗🔍 Ingredients analysis
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #9224 +/- ##
==========================================
+ Coverage 44.30% 49.01% +4.70%
==========================================
Files 64 66 +2
Lines 20333 20422 +89
Branches 4891 4904 +13
==========================================
+ Hits 9008 10009 +1001
+ Misses 10150 9144 -1006
- Partials 1175 1269 +94 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Alex Garel <alex@openfoodfacts.org>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
allow range in percentage.
Example: kakao prah smanjene masti (10-12%) in https://hr.openfoodfacts.org/product/3858886803621
proposed solution: ignore first part of the range, i.e. keep upper value only.
kakao prah smanjene masti (10-12%) -> kakao prah smanjene masti (12%)
Related issue(s) and discussion