Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: fixes in category taxonomy #9354

Merged
merged 2 commits into from
Nov 28, 2023
Merged

taxonomy: fixes in category taxonomy #9354

merged 2 commits into from
Nov 28, 2023

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Nov 21, 2023 •
edited
Loading

Fixes in category taxonomy:

  • wrong translation for chicken in Khmer
  • add fr translations for some vegetables/fruits
  • wrong parents for some categories

@raphael0202 raphael0202 added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Nov 21, 2023
@stephanegigandet
Copy link
Contributor

some errors in tests:

ERROR - fr:myrtilles already is associated to en:bilberries (categories) - fr:myrtilles cannot be mapped to entry en:blueberries
ERROR - fr:pomelos-frais already is associated to en:fresh-grapefruits (categories) - fr:pomelos-frais cannot be mapped to entry fr:pomelos-frais
ERROR - fr:courges-fraiches already is associated to en:fresh-squash (categories) - fr:courges-fraiches cannot be mapped to entry en:fresh-pumpkins

I'll fix them.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 7e43774 into main Nov 28, 2023
13 checks passed
@stephanegigandet stephanegigandet deleted the cat-fixes branch November 28, 2023 16:21
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Nov 28, 2023
Merged
@raphael0202
Copy link
Contributor Author

Thank you for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@raphael0202 raphael0202

Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphael0202 @stephanegigandet