Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make banner matching with design #9450

Merged
merged 2 commits into from
Dec 4, 2023
Merged

fix: Make banner matching with design #9450

merged 2 commits into from
Dec 4, 2023

Conversation

Valimp
Copy link
Collaborator

@Valimp Valimp commented Dec 1, 2023

What

Orange background fit with the text
Better balance with text sizes
SVG responsiveness

Screenshot

New Laptop Version
laptopscreen

New Mobile Version
mobilescreen

@stephanegigandet Some changes requested by @galnaf

@Valimp Valimp requested a review from a team as a code owner December 1, 2023 14:14
@github-actions github-actions bot added CSS Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🎁 donations labels Dec 1, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (d3f8740) 44.30% compared to head (d9192ad) 48.92%.
Report is 6 commits behind head on main.

❗ Current head d9192ad differs from pull request most recent head 3685688. Consider uploading reports for the commit 3685688 to get more accurate results

Files Patch % Lines
lib/ProductOpener/Display.pm 33.33% 13 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9450      +/-   ##
==========================================
+ Coverage   44.30%   48.92%   +4.61%     
==========================================
  Files          64       66       +2     
  Lines       20333    20421      +88     
  Branches     4891     4904      +13     
==========================================
+ Hits         9008     9990     +982     
+ Misses      10150     9161     -989     
- Partials     1175     1270      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@alexgarel alexgarel merged commit 2462d29 into main Dec 4, 2023
13 checks passed
@alexgarel alexgarel deleted the fix-donate-banner branch December 4, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS 🎁 donations Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants