Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Get Logo Annotation list #882

Merged
merged 6 commits into from
Sep 2, 2022
Merged

Conversation

Jagrutiti
Copy link
Member

What

This PR does the following from here:

Next is LogoAnnotationCollection

It's the same thing, with as previous view but for LogoAnnotation:
filters on:

  • barcode
  • type filter (a list of type) keep_types (filter on annotation_type)
  • value_tag (filter on annotation_value_tag)

Part of

@Jagrutiti Jagrutiti requested a review from a team as a code owner August 31, 2022 09:49
@Jagrutiti Jagrutiti requested a review from alexgarel August 31, 2022 09:49
data = result.json
assert data["count"] == 12
assert data["status"] == "found"
assert [q["annotation_value_tag"] for q in data["annotation"]] == [
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test case fails. I should get 5 records but I am getting 12 records all the time.

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #882 (ce40cc0) into master (1e63ca2) will increase coverage by 7.50%.
The diff coverage is 73.71%.

@@            Coverage Diff             @@
##           master     #882      +/-   ##
==========================================
+ Coverage   44.73%   52.24%   +7.50%     
==========================================
  Files          96       92       -4     
  Lines        6981     6950      -31     
==========================================
+ Hits         3123     3631     +508     
+ Misses       3858     3319     -539     
Impacted Files Coverage Δ
robotoff/cli/batch.py 0.00% <ø> (ø)
robotoff/cli/insights.py 0.00% <0.00%> (ø)
robotoff/insights/dataclass.py 100.00% <ø> (ø)
robotoff/prediction/ocr/brand.py 68.62% <0.00%> (ø)
robotoff/prediction/ocr/expiration_date.py 25.71% <ø> (ø)
robotoff/prediction/ocr/label.py 72.30% <0.00%> (ø)
robotoff/prediction/ocr/packager_code.py 73.07% <ø> (ø)
robotoff/prediction/ocr/product_weight.py 49.10% <0.00%> (+1.28%) ⬆️
robotoff/products.py 42.75% <ø> (+2.26%) ⬆️
robotoff/workers/listener.py 0.00% <0.00%> (ø)
... and 60 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot C 1 Security Hotspot
Code Smell A 107 Code Smells

0.0% 0.0% Coverage
0.1% 0.1% Duplication

@alexgarel alexgarel merged commit 965b409 into master Sep 2, 2022
@alexgarel alexgarel deleted the logo-annotation-collection branch September 2, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants