Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle invalid lucene query term values gracefully #268

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

areebahmeddd
Copy link
Member

What

  • Handle invalid Lucene query term values gracefully to prevent HTTP 500 errors.

Screenshot

Fixes bug(s)

Part of

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@areebahmeddd thanks for the PR, well done. It's almost good but you need to run make lint so that the code is well formatted.

Can you do that ?

@alexgarel
Copy link
Member

@areebahmeddd I have updated your branch because I fixed some issues due to a newer version of mypy on branch main.

Please use pre-commit hook to validate your PR.

@areebahmeddd
Copy link
Member Author

@alexgarel Requested changes done, should have done initially haha

@alexgarel
Copy link
Member

@areebahmeddd, sorry there is still an error (import order, see the checks run).

You really should install pre-commit and run it locally, it will solve this kind of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants