fix: 4032 - better paddings for login page (#4037)

* fix: 4032 - better paddings for login page * fix: 4032 - golden generated png files * fix: 4032 - hint text on max 2 lines
openfoodfacts · May 28, 2023 · c60f2a5 · c60f2a5
1 parent e2197d1
commit c60f2a5
Show file tree

Hide file tree

Showing 23 changed files with 5 additions and 8 deletions.
diff --git a/packages/smooth_app/lib/generic_lib/widgets/smooth_text_form_field.dart b/packages/smooth_app/lib/generic_lib/widgets/smooth_text_form_field.dart
@@ -98,6 +98,7 @@ class _SmoothTextFormFieldState extends State<SmoothTextFormField> {
           overflow: TextOverflow.ellipsis,
         ),
         hintText: widget.hintText,
+        hintMaxLines: 2,
         border: const OutlineInputBorder(
           borderRadius: CIRCULAR_BORDER_RADIUS,
         ),

diff --git a/packages/smooth_app/lib/pages/user_management/login_page.dart b/packages/smooth_app/lib/pages/user_management/login_page.dart
@@ -95,7 +95,6 @@ class _LoginPageState extends State<LoginPage> with TraceableClientMixin {
     final Size size = MediaQuery.of(context).size;
 
     return SmoothScaffold(
-      extendBodyBehindAppBar: true,
       statusBarBackgroundColor: SmoothScaffold.semiTranslucentStatusBar,
       contentBehindStatusBar: true,
       fixKeyboard: true,
@@ -113,9 +112,10 @@ class _LoginPageState extends State<LoginPage> with TraceableClientMixin {
             child: Container(
               alignment: Alignment.topCenter,
               width: double.infinity,
-              padding: EdgeInsets.symmetric(
-                horizontal: size.width * 0.15,
-                vertical: size.width * 0.05,
+              padding: EdgeInsets.only(
+                left: size.width * 0.15,
+                right: size.width * 0.15,
+                bottom: size.width * 0.05,
               ),
               child: AutofillGroup(
                 child: Center(
@@ -124,10 +124,6 @@ class _LoginPageState extends State<LoginPage> with TraceableClientMixin {
                     mainAxisAlignment: MainAxisAlignment.center,
                     mainAxisSize: MainAxisSize.min,
                     children: <Widget>[
-                      const SizedBox(
-                        height: LARGE_SPACE * 2,
-                      ),
-
                       SvgPicture.asset(
                         'assets/preferences/login.svg',
                         height: MediaQuery.of(context).size.height * .15,

diff --git a/.../dialogs/generic_lib/goldens/user_preferences_page_dialogs_Improving-amoled.png b/.../dialogs/generic_lib/goldens/user_preferences_page_dialogs_Improving-amoled.png
diff --git a/...st/dialogs/generic_lib/goldens/user_preferences_page_dialogs_Improving-dark.png b/...st/dialogs/generic_lib/goldens/user_preferences_page_dialogs_Improving-dark.png
diff --git a/...t/dialogs/generic_lib/goldens/user_preferences_page_dialogs_Improving-light.png b/...t/dialogs/generic_lib/goldens/user_preferences_page_dialogs_Improving-light.png
diff --git a/...neric_lib/goldens/user_preferences_page_dialogs_Software development-amoled.png b/...neric_lib/goldens/user_preferences_page_dialogs_Software development-amoled.png
diff --git a/...generic_lib/goldens/user_preferences_page_dialogs_Software development-dark.png b/...generic_lib/goldens/user_preferences_page_dialogs_Software development-dark.png
diff --git a/...eneric_lib/goldens/user_preferences_page_dialogs_Software development-light.png b/...eneric_lib/goldens/user_preferences_page_dialogs_Software development-light.png
diff --git a/.../dialogs/generic_lib/goldens/user_preferences_page_dialogs_Translate-amoled.png b/.../dialogs/generic_lib/goldens/user_preferences_page_dialogs_Translate-amoled.png
diff --git a/...st/dialogs/generic_lib/goldens/user_preferences_page_dialogs_Translate-dark.png b/...st/dialogs/generic_lib/goldens/user_preferences_page_dialogs_Translate-dark.png
diff --git a/...t/dialogs/generic_lib/goldens/user_preferences_page_dialogs_Translate-light.png b/...t/dialogs/generic_lib/goldens/user_preferences_page_dialogs_Translate-light.png
diff --git a/packages/smooth_app/test/pages/goldens/user_preferences_page-amoled.png b/packages/smooth_app/test/pages/goldens/user_preferences_page-amoled.png
diff --git a/packages/smooth_app/test/pages/goldens/user_preferences_page-dark.png b/packages/smooth_app/test/pages/goldens/user_preferences_page-dark.png
diff --git a/packages/smooth_app/test/pages/goldens/user_preferences_page-light.png b/packages/smooth_app/test/pages/goldens/user_preferences_page-light.png
diff --git a/packages/smooth_app/test/users/goldens/forgot_password_page-amoled.png b/packages/smooth_app/test/users/goldens/forgot_password_page-amoled.png
diff --git a/packages/smooth_app/test/users/goldens/forgot_password_page-dark.png b/packages/smooth_app/test/users/goldens/forgot_password_page-dark.png
diff --git a/packages/smooth_app/test/users/goldens/forgot_password_page-light.png b/packages/smooth_app/test/users/goldens/forgot_password_page-light.png
diff --git a/packages/smooth_app/test/users/goldens/login_page-amoled.png b/packages/smooth_app/test/users/goldens/login_page-amoled.png
diff --git a/packages/smooth_app/test/users/goldens/login_page-dark.png b/packages/smooth_app/test/users/goldens/login_page-dark.png
diff --git a/packages/smooth_app/test/users/goldens/login_page-light.png b/packages/smooth_app/test/users/goldens/login_page-light.png
diff --git a/packages/smooth_app/test/users/goldens/signup_page-amoled.png b/packages/smooth_app/test/users/goldens/signup_page-amoled.png
diff --git a/packages/smooth_app/test/users/goldens/signup_page-dark.png b/packages/smooth_app/test/users/goldens/signup_page-dark.png
diff --git a/packages/smooth_app/test/users/goldens/signup_page-light.png b/packages/smooth_app/test/users/goldens/signup_page-light.png