Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to keep the nutrition table expanded #2364

Closed
teolemon opened this issue Jun 23, 2022 · 1 comment · Fixed by #2634
Closed

Add an option to keep the nutrition table expanded #2364

teolemon opened this issue Jun 23, 2022 · 1 comment · Fixed by #2634
Assignees
@cli1005
Labels
📖 Knowledge panels - Local overrides 📖 Knowledge panels nutrition facts 🎯 P1
Milestone
V1.1

Comments

@teolemon
Copy link
Member

teolemon commented Jun 23, 2022 •
edited
Loading

What

  • Add an option in the App settings to keep the nutrition table knowledge panel expanded, regardless of the instruction sent by the Knowledge Panel API
  • We can probably add the same option for ingredients
@teolemon teolemon added this to the V1.1 milestone Jun 23, 2022
@cli1005 cli1005 self-assigned this Jun 24, 2022
@cli1005 cli1005 moved this from To discuss and validate to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 24, 2022
@cli1005
Copy link
Contributor

cli1005 commented Jun 27, 2022

Two options with default value = true have been added in the App Setting, Please tell me if it is not OK for you:

Image

Simulator.Screen.Recording.-.iPhone.13.-.2022-06-25.at.23.33.45.mp4

cli1005 added a commit to cli1005/smooth-app that referenced this issue Jun 27, 2022
@cli1005
feat: openfoodfacts#2364 expand nutrition ingredients
4fefa10
@cli1005 cli1005 mentioned this issue Jun 27, 2022
Closed
@cli1005 cli1005 moved this from In Progress to Pull Requests in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jun 27, 2022
cli1005 added a commit to cli1005/smooth-app that referenced this issue Jun 27, 2022
@cli1005
feat: openfoodfacts#2364 refactoring codereview
b77c92c
cli1005 added a commit to cli1005/smooth-app that referenced this issue Jun 27, 2022
@cli1005
feat: openfoodfacts#2364 refactoring
68e9b98
cli1005 added a commit to cli1005/smooth-app that referenced this issue Jun 28, 2022
@cli1005
feat:openfoodfacts#2364 refactoring
3ef88b2
cli1005 added a commit to cli1005/smooth-app that referenced this issue Jun 29, 2022
@cli1005
feat: openfoodfacts#2364 fix presubmit
dee75b5
cli1005 added a commit to cli1005/smooth-app that referenced this issue Jul 1, 2022
@cli1005
feat:openfoodfacts#2364 revert
32c706d
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 20, 2022
@monsieurtanuki
feat: openfoodfacts#2364 - new preferences toggles for ingredients / …
3fa9ac9 
…nutrition expand mode

Impacted files:
* `app_en.arb`: added labels for preferences toggles (ingredients and nutrition)
* `knowledge_panel_card.dart`: now uses the new expand flags to expand the contents (or not)
* `user_preferences_settings.dart`: added 2 preferences toggles (expand ingredients / nutrition)
@monsieurtanuki monsieurtanuki mentioned this issue Jul 20, 2022
Merged
monsieurtanuki added a commit that referenced this issue Jul 22, 2022
@monsieurtanuki
feat: #2364 - new preferences toggles for ingredients / nutrition exp…
cc7c062 
…and mode (#2634)

Impacted files:
* `app_en.arb`: added labels for preferences toggles (ingredients and nutrition)
* `knowledge_panel_card.dart`: now uses the new expand flags to expand the contents (or not)
* `user_preferences_settings.dart`: added 2 preferences toggles (expand ingredients / nutrition)
Repository owner moved this from Pull Requests to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 22, 2022
@github-actions github-actions bot mentioned this issue Jul 22, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cli1005 cli1005

Labels
📖 Knowledge panels - Local overrides 📖 Knowledge panels nutrition facts 🎯 P1
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1.1
2 participants
@teolemon @cli1005