Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the language switcher available to all users #2503

Closed
1 task
Tracked by #960
teolemon opened this issue Jul 5, 2022 · 3 comments · Fixed by #2658
Closed
1 task
Tracked by #960

Make the language switcher available to all users #2503

teolemon opened this issue Jul 5, 2022 · 3 comments · Fixed by #2658
Assignees
@monsieurtanuki
Labels
⚙️ Settings

Comments

@teolemon
Copy link
Member

teolemon commented Jul 5, 2022 •
edited
Loading

What

  • Make the language switcher available to all users
  • user feedback: "Bonjour je n'arrive pas a mettre mon application en français. La langue de mon Iphone est en portugais mais je veux que cette application soit en francais, car quand je cherche une produit dans la barre de recherche je ne le trouve pas s'il n'est pas tapé en portugais.

Bien a vous.

  • "Hello, I can't put my application in French. The language of my Iphone is in Portuguese but I want this application to be in French, because when I look for a product in the search bar I cannot find it if it is not typed in Portuguese.

Good for you."

Part of
@g123k
Copy link
Collaborator

g123k commented Jul 5, 2022

If I understand well, we should provide two fields:

  • one for the server location (which is already available in the app)
  • one for the app language

Was-it done like this in V1?

@teolemon
Copy link
Member Author

teolemon commented Jul 5, 2022

Nope, we didn't have a notion of country for the Eco-Score.

@teolemon teolemon mentioned this issue Jul 6, 2022
Open
11 tasks
@AshAman999 AshAman999 mentioned this issue Jul 22, 2022
Merged
@teolemon teolemon mentioned this issue Jul 23, 2022
Open
@teolemon
Copy link
Member Author

Νίκος Ραπτόπουλος
1 ★
Greek
Illegible characters (basically unusable) in Greek, and cannot switch display language. TCL T767H

@teolemon teolemon mentioned this issue Jul 25, 2022
Closed
@monsieurtanuki monsieurtanuki self-assigned this Jul 25, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 25, 2022
@monsieurtanuki
feat: openfoodfacts#2503 - language selector now in "App Settings" (f…
ac8d68c 
…or all users)

Impacted files:
* `language_selector.dart`: refactored for consistent data and filter
* `user_preferences_dev_mode.dart`: removed the language selector
* `user_preferences_settings.dart`: put the language selector, slightly refactored for UI consistency with country selector
@monsieurtanuki monsieurtanuki mentioned this issue Jul 25, 2022
Merged
monsieurtanuki added a commit that referenced this issue Jul 25, 2022
@monsieurtanuki
feat: #2503 - language selector now in "App Settings" (for all users) (…
0c5fab5 
…#2658)

Impacted files:
* `language_selector.dart`: refactored for consistent data and filter
* `user_preferences_dev_mode.dart`: removed the language selector
* `user_preferences_settings.dart`: put the language selector, slightly refactored for UI consistency with country selector
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 25, 2022
@github-actions github-actions bot mentioned this issue Jul 25, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
⚙️ Settings
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #2503 - language selector now in "App Settings" (for all users) monsieurtanuki/smooth-app
3 participants
@g123k @teolemon @monsieurtanuki