Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Illegible for color blind people and presbyopia (RGAA): texts in light orange font #2530

Closed
1 task
Tracked by #2318
teolemon opened this issue Jul 7, 2022 · 2 comments · Fixed by #2569
Closed
1 task
Tracked by #2318

Illegible for color blind people and presbyopia (RGAA): texts in light orange font #2530

teolemon opened this issue Jul 7, 2022 · 2 comments · Fixed by #2569
Labels
♿️ accessibility

Comments

@teolemon
Copy link
Member

teolemon commented Jul 7, 2022 •
edited
Loading

What

From a user report:

  • Illegible for color blind people and presbyopia (RGAA): texts in light orange font

Part of

  • Accessibility
@teolemon teolemon mentioned this issue Jul 7, 2022
Closed
55 tasks
@teolemon teolemon changed the title Negative point, illegible for color blind people and presbyopia (RGAA): texts in light orange font :( Illegible for color blind people and presbyopia (RGAA): texts in light orange font Jul 7, 2022
@teolemon teolemon mentioned this issue Jul 7, 2022
Closed
@monsieurtanuki
Copy link
Contributor

Suggested tool for color contrast compliancy: https://webaim.org/resources/contrastchecker/

In addition to contrasted enough colors - so that the text is legible by anybody - comes the question of color blind people - where the difference between red and orange is too hard to see.

A suggestion: texts always in black (or white)
And

  • either a different multicolor icon according to the level (like smiling emoji)
  • or a different tinted icon colored according to the level

@monsieurtanuki
Copy link
Contributor

monsieurtanuki commented Jul 8, 2022 •
edited
Loading

Weather Emoji suggestion:

before after
Capture d’écran 2022-07-08 à 18 33 14 Capture d’écran 2022-07-08 à 18 34 03

[Edit: added]
And with the sun:
Capture d’écran 2022-07-10 à 08 03 38

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 10, 2022
@monsieurtanuki
fix: openfoodfacts#2530 - replaced the score colors with a score emoji
4151ddb 
Impacted file:
* `knowledge_panel_title_card.dart`: replaced the score colors with a score emoji as a test, with a simple way to roll back to the previous version for comparison purposes
@monsieurtanuki monsieurtanuki mentioned this issue Jul 10, 2022
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 10, 2022
@monsieurtanuki
fix: openfoodfacts#2530 - to the "new" mode
3c59c10 
Impacted file:
* `knowledge_panel_title_card.dart`
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 19, 2022
@monsieurtanuki
Merge branch 'develop' into fix/openfoodfacts#2530
b92ebff
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 19, 2022
@monsieurtanuki
fix: openfoodfacts#2530 - dev mode settings and new emoji
951ca01 
Impacted files:
* `knowledge_panel_title_card.dart`: now using preferences; new emoji
* `user_preferences_dev_mode.dart`: 2 new settings/preferences - emoji, and no color
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 19, 2022
@monsieurtanuki
Merge remote-tracking branch 'origin/fix/openfoodfacts#2530' into fix/o…
bac3939 
…penfoodfacts#2530
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 20, 2022
@monsieurtanuki
fix: openfoodfacts#2530 - replaced String emoji with IconData
bd48e8d 
Impacted file:
* `knowledge_panel_title_card.dart`: replaced `String` emoji with `IconData`
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 21, 2022
@github-actions github-actions bot mentioned this issue Jul 21, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
♿️ accessibility
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2530 - replaced the score colors with a score emoji monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki