Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input in mg is saved as g for sodium #2561

Closed
teolemon opened this issue Jul 9, 2022 · 0 comments
Closed

Input in mg is saved as g for sodium #2561

teolemon opened this issue Jul 9, 2022 · 0 comments
Assignees
@monsieurtanuki
Labels
✏️ Editing - Nutrition input 🎯 P0

Comments

@teolemon
Copy link
Member

teolemon commented Jul 9, 2022

What

Reported by Sumit
image
image
image
https://world.openfoodfacts.org/product/8901242604709/ginger-garlic-paste-bambind
image

Part of
@monsieurtanuki monsieurtanuki self-assigned this Jul 10, 2022
@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 10, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 10, 2022
@monsieurtanuki
fix: openfoodfacts#2561 - fixed value+unit management in nutrient page
0254804 
Impacted files:
* `nutrition_page_loaded.dart`: little fix - now we consider the page edited also when at least one unit changed.
* `nutrition_container.dart`: fix - now we populate units and we don't convert values when saving to the server; added initial units field for the "were units edited?" check; refactored
@monsieurtanuki monsieurtanuki mentioned this issue Jul 10, 2022
Merged
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 19, 2022
@github-actions github-actions bot mentioned this issue Jul 19, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
✏️ Editing - Nutrition input 🎯 P0
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @monsieurtanuki