fix: #2561 - fixed value+unit management in nutrient page #2568
+83
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `nutrition_page_loaded.dart`: little fix - now we consider the page edited also when at least one unit changed. * `nutrition_container.dart`: fix - now we populate units and we don't convert values when saving to the server; added initial units field for the "were units edited?" check; refactored
Codecov Report
@@ Coverage Diff @@
## develop #2568 +/- ##
==========================================
- Coverage 8.86% 7.56% -1.31%
==========================================
Files 161 210 +49
Lines 6623 10090 +3467
==========================================
+ Hits 587 763 +176
- Misses 6036 9327 +3291
Continue to review full report at Codecov.
|
g123k
requested changes
Jul 12, 2022
| void _setUnit( | ||
| final String nutrientId, | ||
| final Unit unit, { | ||
| required final bool init, |
There was a problem hiding this comment.
Could you document this field please?
There was a problem hiding this comment.
I don't believe in comments here:
- it's a private method
- the parameter has a decent name (
init? "it must have something to do with the init phase") - the method is used only twice, first time at init time with
init: true, and later withinit: false
| final String text = controller.value.text; | ||
| final double? value = getValue(key); | ||
| if (value == null) { | ||
| if (text != '') { |
There was a problem hiding this comment.
isNotEmpty wouldn't be better here?
There was a problem hiding this comment.
I guess it would have been the same.
M123-dev
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
nutrition_page_loaded.dart: little fix - now we consider the page edited also when at least one unit changed.nutrition_container.dart: fix - now we populate units and we don't convert values when saving to the server; added initial units field for the "were units edited?" check; refactoredWhat
0.12andmg, which means 0.12 grams to be displayed in mg, therefore as "120 mg"). You have to convert the value from grams into the given unit.120andmg(more intuitive)Should we automatically compute one from the other in the app?
Part of