Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse the icons from the knowledge panels for ingredients and nutrition edit #2572

Closed
teolemon opened this issue Jul 11, 2022 · 0 comments · Fixed by #2577
Closed

Reuse the icons from the knowledge panels for ingredients and nutrition edit #2572

teolemon opened this issue Jul 11, 2022 · 0 comments · Fixed by #2577
Assignees
@monsieurtanuki
Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✨ enhancement New feature or request

Comments

@teolemon
Copy link
Member

What

  • Reuse the icons from the knowledge panels for ingredients and nutrition edit sections, in edit mode

Part of
@teolemon teolemon added ✨ enhancement New feature or request ✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users labels Jul 11, 2022
@monsieurtanuki monsieurtanuki self-assigned this Jul 11, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 11, 2022
@monsieurtanuki
feat: openfoodfacts#2572 - added icons for ingredients and nutrition …
9748ad3 
…in edit product page

Impacted file:
* `edit_product_page.dart`: added svg icons for ingredients and nutrition
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jul 11, 2022
@monsieurtanuki
feat: openfoodfacts#2572 - dark mode fix
541f002 
Impacted file:
* `edit_product_page.dart`
@monsieurtanuki monsieurtanuki mentioned this issue Jul 11, 2022
Merged
monsieurtanuki added a commit that referenced this issue Jul 11, 2022
@monsieurtanuki
feat: #2572 - added icons for ingredients and nutrition in edit produ…
168d468 
…ct page (#2577)

Impacted file:
* `edit_product_page.dart`: added svg icons for ingredients and nutrition
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Jul 11, 2022
@github-actions github-actions bot mentioned this issue Jul 19, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
✏️ Contribution ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users ✨ enhancement New feature or request
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
2 participants
@teolemon @monsieurtanuki