feat: #2503 - language selector now in "App Settings" (for all users) #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or all users) Impacted files: * `language_selector.dart`: refactored for consistent data and filter * `user_preferences_dev_mode.dart`: removed the language selector * `user_preferences_settings.dart`: put the language selector, slightly refactored for UI consistency with country selector
AshAman999
approved these changes
Jul 25, 2022
|
Thank you @AshAman999 for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
language_selector.dart: refactored for consistent data and filteruser_preferences_dev_mode.dart: removed the language selectoruser_preferences_settings.dart: put the language selector, slightly refactored for UI consistency with country selectorWhat
Screenshot
Fixes bug(s)