Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sign button stays even when I am signed in already #2706

Closed
AshAman999 opened this issue Aug 1, 2022 · 0 comments · Fixed by #2714
Closed

The sign button stays even when I am signed in already #2706

AshAman999 opened this issue Aug 1, 2022 · 0 comments · Fixed by #2714
Assignees
@monsieurtanuki
Labels
before next release obvious and / or dangerous bug 🐛 bug Something isn't working good first issue Good for newcomers 👥 User management Account login, signup, signout ⏲️ 5 minute fix

Comments

@AshAman999
Copy link
Member

What

  • Even when I am signed in, I still see the sign-in button

Steps to reproduce the behavior

  1. Go to the profile section
  2. Click on Sign In button
  3. Sign in to your account
  4. The button is still in the profile section

Expected behavior

The button should disappear when I am signed in

Why

  • (optional, delete if empty) Why it's important

Screenshot/Mockup/Before-After

image

Smartphone model

  • Device: [Emulator]
  • OS: [Android 11]
@teolemon teolemon added 🐛 bug Something isn't working 👥 User management Account login, signup, signout labels Aug 1, 2022
@VaiTon VaiTon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 1, 2022
@monsieurtanuki monsieurtanuki added ⏲️ 5 minute fix before next release obvious and / or dangerous bug labels Aug 1, 2022
@AshAman999 AshAman999 added the good first issue Good for newcomers label Aug 1, 2022
@monsieurtanuki monsieurtanuki self-assigned this Aug 2, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Aug 2, 2022
@monsieurtanuki
fix: openfoodfacts#2706 - now we display the "LOGIN!" button only if …
a9a88fb 
…not logged in

Impacted files:
* `abstract_user_preferences.dart`: added an "additional subtitle" method, returning a `null` widget by default
* `user_preferences_account.dart`: (only) implementation of the "additional subtitle", that displays the "LOGIN!" button, but only if not logged in (that's the issue fix)
* `user_preferences_page.dart`: now we let each item decide if there's an additional subtitle to display beyond the list tile (and its layout constraints)
@monsieurtanuki monsieurtanuki mentioned this issue Aug 2, 2022
Merged
monsieurtanuki added a commit that referenced this issue Aug 2, 2022
@monsieurtanuki
fix: #2706 - now we display the "LOGIN!" button only if not logged in (…
a845721 
…#2714)

Impacted files:
* `abstract_user_preferences.dart`: added an "additional subtitle" method, returning a `null` widget by default
* `user_preferences_account.dart`: (only) implementation of the "additional subtitle", that displays the "LOGIN!" button, but only if not logged in (that's the issue fix)
* `user_preferences_page.dart`: now we let each item decide if there's an additional subtitle to display beyond the list tile (and its layout constraints)
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 2, 2022
@github-actions github-actions bot mentioned this issue Aug 2, 2022
Merged
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
before next release obvious and / or dangerous bug 🐛 bug Something isn't working good first issue Good for newcomers 👥 User management Account login, signup, signout ⏲️ 5 minute fix
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2706 - now we display the "LOG IN!" button only if not logged in monsieurtanuki/smooth-app
3 participants
@teolemon @monsieurtanuki @AshAman999