Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close button not working properly on Product search Page #2729

Closed
abughalib opened this issue Aug 5, 2022 · 3 comments · Fixed by #2736
Closed

Close button not working properly on Product search Page #2729

abughalib opened this issue Aug 5, 2022 · 3 comments · Fixed by #2736
Assignees
@monsieurtanuki
Labels
🐛 bug Something isn't working 🔎 Search

Comments

@abughalib
Copy link
Contributor

What

The close button on the product scan page is not closing the dialog

Steps to reproduce the behavior

  1. Go to Search
  2. Search for any product
  3. Scroll down and click on Close

Screen Recording

screen-20220805-154335_Trim.mp4

Smartphone model

  • Device: Realme 3 Pro (RMX1851), Pixel 4 Emulator, Windows Subsystem Android
  • OS: Lineage OS 19.1 (Android 12), Android 13, Android 12
@monsieurtanuki monsieurtanuki self-assigned this Aug 5, 2022
@monsieurtanuki
Copy link
Contributor

Thank you @abughalib for having detected this bug. Strange, it didn't happen when I coded it.
That said, I think I'll get rid of the "close" button: no error then ;)
And put the banner in a sliver instead.
Because anyway, it was a bit strange (assuming that the close button works, yes it did), that when you close the banner and then say "hey, finally I would like world data" you could not anymore as the banner was dismissed.

@monsieurtanuki
Copy link
Contributor

Working on a more simple version. Should be ready tomorrow.
Capture d’écran 2022-08-05 à 21 26 35

@monsieurtanuki
Copy link
Contributor

And that gives me the opportunity to improve the "empty screen" too:
Capture d’écran 2022-08-05 à 22 09 12

monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Aug 6, 2022
@monsieurtanuki
fix: openfoodfacts#2729 - product query page - simplified top message…
a6a6839 
…s and buttons

Impacted files:
* `product_query_page.dart`: now displaying actions as app bar icon buttons (and large buttons for empty results); replaced the banner with a simple card; refactored
* `product_query_page_helper.dart`: minor refactoring
@monsieurtanuki monsieurtanuki mentioned this issue Aug 6, 2022
Merged
@teolemon teolemon added 🐛 bug Something isn't working 🔎 Search labels Aug 6, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Aug 10, 2022
@monsieurtanuki
fix: openfoodfacts#2729 - simplified display; display country name
9823002 
Impacted files:
* `app_en.arb`: resized "world" labels - one shorter, one longer
* `app_fr.arb`: resized "world" labels - one shorter, one longer
* `product_query_page.dart`: no more display of "everything downloaded" final text; no more "refresh" large button; displays country name in the result summary
monsieurtanuki added a commit that referenced this issue Aug 10, 2022
@monsieurtanuki
fix: #2729 - product query page - simplified top messages and buttons (…
dee9be3 
…#2736)

Impacted files:
* `app_en.arb`: resized "world" labels - one shorter, one longer
* `app_fr.arb`: resized "world" labels - one shorter, one longer
* `product_query_page.dart`: now displaying actions as app bar icon buttons (and large buttons for empty results); replaced the banner with a simple card; refactored; no more display of "everything downloaded" final text; no more "refresh" large button; displays country name in the result summary
* `product_query_page_helper.dart`: minor refactoring
@github-actions github-actions bot mentioned this issue Aug 10, 2022
Merged
@github-actions github-actions bot mentioned this issue Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
🐛 bug Something isn't working 🔎 Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2729 - product query page - simplified top messages and buttons monsieurtanuki/smooth-app
3 participants
@teolemon @monsieurtanuki @abughalib