Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The app should refresh sub-knowledge panels after category addition #2833

Closed
teolemon opened this issue Aug 23, 2022 · 0 comments · Fixed by #2861
Closed

The app should refresh sub-knowledge panels after category addition #2833

teolemon opened this issue Aug 23, 2022 · 0 comments · Fixed by #2861
Assignees
@monsieurtanuki
Labels
data refresh 📖 Knowledge panels P2 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.

Comments

@teolemon
Copy link
Member

What

  • The app should refresh sub-knowledge panels after category addition

Steps to reproduce the behavior

  1. Go to a product without a category (and thus no Nutri-Score nor Eco-Scores)
  2. Click on the grey Eco-Score or Nutri-Score to help
  3. Click on the Add category button, add category and save
  4. Go back to the sub-knowledge panel. It is not reloaded and the score does not appear
  5. Go back to the main product page. The score do appear this time.

Expected behavior

The scores appear on the sub-knowledge panels immediately after category addition

Why

  • Instant satisfaction/feedback, an action provokes a result

Part of
@teolemon teolemon added 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users. 📖 Knowledge panels labels Aug 23, 2022
@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 23, 2022
@monsieurtanuki monsieurtanuki self-assigned this Aug 24, 2022
@monsieurtanuki monsieurtanuki mentioned this issue Aug 25, 2022
Closed
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Aug 30, 2022
@monsieurtanuki
fix: openfoodfacts#2833 - KP page refreshed by product (refactoring w…
e16df77 
…as needed)

Impacted files:
* `knowledge_panel_card.dart`: refactored the call to  `KnowledgePanelPage`
* `knowledge_panel_element_card.dart`: refactored the calls to `KnowledgePanelCard` and `KnowledgePanelGroupCard`
* `knowledge_panel_expanded_card.dart`: refactored the call to `KnowledgePanelElementCard`
* `knowledge_panel_group_card.dart`: refactored the call to `KnowledgePanelCard`
* `knowledge_panel_page.dart`: refactored the call to `KnowledgePanelExpandedCard`; we use a `Consumer` in order to refresh when the product is refreshed
* `knowledge_panel_page_template.dart`; refactored the call to `KnowledgePanelWidget`
* `knowledge_panels_builder.dart`: refactored the call to `KnowledgePanelElementCard`
* `new_product_page.dart`: refactored the call to `KnowledgePanelWidget`
* `simple_input_page.dart`: unrelated "vertical axis" for verbose buttons
* `summary_card.dart`: refactored the call to `KnowledgePanelPage`
This was referenced Aug 30, 2022
Merged
Merged
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Sep 6, 2022
@monsieurtanuki
Merge branch 'develop' into fix/openfoodfacts#2833
c4aeec1
monsieurtanuki added a commit that referenced this issue Sep 7, 2022
@monsieurtanuki
fix: #2833 - KP page refreshed by product (refactoring was needed) (#…
e57cc0f 
…2861)

Impacted files:
* `knowledge_panel_card.dart`: refactored the call to  `KnowledgePanelPage`
* `knowledge_panel_element_card.dart`: refactored the calls to `KnowledgePanelCard` and `KnowledgePanelGroupCard`
* `knowledge_panel_expanded_card.dart`: refactored the call to `KnowledgePanelElementCard`
* `knowledge_panel_group_card.dart`: refactored the call to `KnowledgePanelCard`
* `knowledge_panel_page.dart`: refactored the call to `KnowledgePanelExpandedCard`; we use a `Consumer` in order to refresh when the product is refreshed
* `knowledge_panel_page_template.dart`; refactored the call to `KnowledgePanelWidget`
* `knowledge_panels_builder.dart`: refactored the call to `KnowledgePanelElementCard`
* `new_product_page.dart`: refactored the call to `KnowledgePanelWidget`
* `simple_input_page.dart`: unrelated "vertical axis" for verbose buttons
* `summary_card.dart`: refactored the call to `KnowledgePanelPage`
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Sep 7, 2022
@github-actions github-actions bot mentioned this issue Sep 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
data refresh 📖 Knowledge panels P2 🛣️ Road to scores The easier it is to get Nutri-Score, Eco-Score, the happier the users.
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #2833 - KP page refreshed by product (refactoring was needed) monsieurtanuki/smooth-app
2 participants
@teolemon @monsieurtanuki