Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We need autocomplete for the origin field #3209

Closed
M123-dev opened this issue Oct 24, 2022 · 4 comments · Fixed by #3230
Closed

We need autocomplete for the origin field #3209

M123-dev opened this issue Oct 24, 2022 · 4 comments · Fixed by #3230
Assignees
@AshAman999
Labels
autosuggest ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users

Comments

@M123-dev
Copy link
Member

No description provided.

@M123-dev M123-dev mentioned this issue Oct 24, 2022
Open
@M123-dev
Copy link
Member Author

https://world.openfoodfacts.org/cgi/suggest.pl?tagtype=origins&term=fr&lc=en

@teolemon teolemon added ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users autosuggest labels Oct 25, 2022
@AshAman999 AshAman999 self-assigned this Oct 25, 2022
@AshAman999
Copy link
Member

@M123-dev
If I am not wrong #596 has been merged but not yet in release, so I should wait for it be in the next off release

@M123-dev
Copy link
Member Author

M123-dev commented Oct 27, 2022 •
edited
Loading

Yes @AshAman999 good catch

Blocked on openfoodfacts/openfoodfacts-dart#599 Not anymore

@monsieurtanuki
Copy link
Contributor

Just upgrade off-dart to 1.27.0. It's very easy.

AshAman999 added a commit to AshAman999/smooth-app that referenced this issue Oct 29, 2022
@AshAman999
added auto completed for origins openfoodfacts#3209
0dc17b6
@AshAman999 AshAman999 mentioned this issue Oct 29, 2022
Merged
AshAman999 added a commit that referenced this issue Oct 29, 2022
@AshAman999
fix: added auto complete text field for origins #3209 (#3230)
a3608be
Repository owner moved this from To discuss and validate to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Oct 29, 2022
@github-actions github-actions bot mentioned this issue Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AshAman999 AshAman999

Labels
autosuggest ✏️ Editing Many products are incomplete and don't have Nutri-Score, Eco-Score…so editing is important for users
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: added auto complete text field for origins #3209 AshAman999/smooth-app
4 participants
@teolemon @monsieurtanuki @M123-dev @AshAman999